You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by ne...@apache.org on 2022/12/13 00:00:37 UTC

[helix] branch nealsun/waged-pipeline-redesign updated: Fix rebalancer failure counter in async scenario (#2318)

This is an automated email from the ASF dual-hosted git repository.

nealsun pushed a commit to branch nealsun/waged-pipeline-redesign
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/nealsun/waged-pipeline-redesign by this push:
     new 47f6a3d18 Fix rebalancer failure counter in async scenario (#2318)
47f6a3d18 is described below

commit 47f6a3d18a1347a8c9c149a52fba93a3694acfc4
Author: Neal Sun <ne...@linkedin.com>
AuthorDate: Mon Dec 12 16:00:30 2022 -0800

    Fix rebalancer failure counter in async scenario (#2318)
    
    Co-authored-by: Neal Sun <ne...@nesun-mn2.linkedin.biz>
---
 .../org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java b/helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
index 0c1b09395..ff8e33b28 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
@@ -460,6 +460,7 @@ public class WagedRebalancer implements StatefulRebalancer<ResourceControllerDat
           doGlobalRebalance(clusterData, resourceMap, algorithm, currentStateOutput, !waitForGlobalRebalance,
               clusterChanges);
         } catch (HelixRebalanceException e) {
+          _rebalanceFailureCount.increment(1L);
           LOG.error("Failed to calculate baseline assignment!", e);
           return false;
         }
@@ -549,6 +550,7 @@ public class WagedRebalancer implements StatefulRebalancer<ResourceControllerDat
         doPartialRebalance(clusterData, resourceMap, activeNodes, algorithm,
             currentStateOutput);
       } catch (HelixRebalanceException e) {
+        _rebalanceFailureCount.increment(1L);
         LOG.error("Failed to calculate best possible assignment!", e);
         return false;
       }