You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/14 01:35:24 UTC
Review Request: Fixed killtree to guard against session ids being reported
as '0' by '/bin/ps' on OSX 10.8.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9915/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Thomas Marshall, and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/scripts/killtree.sh 1ec8efca2fd2c72208995cdf2f819ecb765f4c88
Diff: https://reviews.apache.org/r/9915/diff/
Testing
-------
Tested on MacOSX10.8
Thanks,
Vinod Kone
Re: Review Request: Fixed killtree to guard against session ids being
reported as '0' by '/bin/ps' on OSX 10.8.
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9915/#review17839
-----------------------------------------------------------
Ship it!
- Thomas Marshall
On March 14, 2013, 12:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9915/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Thomas Marshall, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scripts/killtree.sh 1ec8efca2fd2c72208995cdf2f819ecb765f4c88
>
> Diff: https://reviews.apache.org/r/9915/diff/
>
>
> Testing
> -------
>
> Tested on MacOSX10.8
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed killtree to guard against session ids being
reported as '0' by '/bin/ps' on OSX 10.8.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9915/#review17843
-----------------------------------------------------------
Ship it!
For posterity, it will be interesting to see how my future OSX "proc" utilities report session ids. If they are valid, then we should definitely implement the killtree script programmatically instead of as an external script.
- Ben Mahler
On March 14, 2013, 12:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9915/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Thomas Marshall, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scripts/killtree.sh 1ec8efca2fd2c72208995cdf2f819ecb765f4c88
>
> Diff: https://reviews.apache.org/r/9915/diff/
>
>
> Testing
> -------
>
> Tested on MacOSX10.8
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed killtree to guard against session ids being
reported as '0' by '/bin/ps' on OSX 10.8.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9915/#review17838
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 14, 2013, 12:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9915/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Thomas Marshall, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scripts/killtree.sh 1ec8efca2fd2c72208995cdf2f819ecb765f4c88
>
> Diff: https://reviews.apache.org/r/9915/diff/
>
>
> Testing
> -------
>
> Tested on MacOSX10.8
>
>
> Thanks,
>
> Vinod Kone
>
>