You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/18 06:56:56 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new issue, #496: [Subtask][operator] set init-container's resource request
advancedxy opened a new issue, #496:
URL: https://github.com/apache/incubator-uniffle/issues/496
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues) and found no similar issues.
### Describe the subtask
uniffle's rss operator generate init-container without resource requirement, which normally could be acceptable.
But when deployed to namespace with resource quota, every pod should set its resource request, otherwise the controller could reject the pod creation.
Therefore rss operator should set coordinator and shuffle server's init-container with resource request inferred.
<img width="1732" alt="image" src="https://user-images.githubusercontent.com/807537/213104431-33e4699c-7173-4743-a4c8-7516b578a26f.png">
### Parent issue
#462
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #496: [Subtask][operator] set init-container's resource request
Posted by GitBox <gi...@apache.org>.
advancedxy commented on issue #496:
URL: https://github.com/apache/incubator-uniffle/issues/496#issuecomment-1386801023
> Do you mean uniffle should set the default resource request? like that
>
> 
Yes and no.
- Yeah: uniffle's coordinator and shuffle server's init-container(auto appended by operator) should has non-empty resource field.
- No: rss operator don't need to set a default resource request. https://github.com/apache/incubator-uniffle/blob/master/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go#L225 rss crd already defines the resource field. The auto-generated init-container should inherit this requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy closed issue #496: [Subtask][operator] set init-container's resource request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy closed issue #496: [Subtask][operator] set init-container's resource request
URL: https://github.com/apache/incubator-uniffle/issues/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #496: [Subtask][operator] set init-container's resource request
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #496:
URL: https://github.com/apache/incubator-uniffle/issues/496#issuecomment-1386707714
Do you mean uniffle should set the default resource request? like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org