You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/09 04:50:57 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #4264: [HUDI-2875] Make HoodieParquetWriter Thread safe and memory executor …

nsivabalan commented on a change in pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#discussion_r802266410



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/queue/BoundedInMemoryQueue.java
##########
@@ -204,6 +204,7 @@ private boolean expectMoreRecords() {
    * singleton iterator for this queue.
    */
   private Option<O> readNextRecord() {
+    checkIfInterrupted();

Review comment:
       do we need to check if interrupted for every record processing? will there be any negative impact on perf due to this. This is all in memory, and should not be an issue. but wanted to see if this is absolutely necessary. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org