You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/05 15:10:38 UTC
[GitHub] [incubator-echarts-doc] susiwen8 opened a new pull request #86: Fix
doc
susiwen8 opened a new pull request #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] susiwen8 closed pull request #86: Fix doc
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] pissang commented on issue #86: Fix doc
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86#issuecomment-571017021
So weird, why GitHub shows the whole file `axis-common.md` is changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] susiwen8 commented on issue #86: Fix doc
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86#issuecomment-572589321
> So weird, why GitHub shows the whole file `axis-common.md` is changed
Might related to this https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not
I resolved conflit on Github, not on vscode I use to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] pissang commented on a change in pull
request #86: Fix doc
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86#discussion_r363137371
##########
File path: en/option/series/line.md
##########
@@ -37,7 +37,7 @@ Broken line chart relates all the data points [symbol](~series-line.symbol) by b
## showSymbol(boolean) = true
Whether to show symbol. It would be shown during tooltip hover.
-## showAllSymbol(boolean) = 'auto'
+## showAllSymbol(boolean|string) = 'auto'
Review comment:
For the property which value can be `'auto'`. I think we can ignore the `string` type. Because `'auto'` is a very special value. It's similar to `null/undefined` but with semantic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] susiwen8 commented on issue #86: Fix doc
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86#issuecomment-572594640
Just create a new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] pissang commented on issue #86: Fix doc
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #86: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/86#issuecomment-570977730
Aa always, thanks siwen! I've left my comment about the `type` of property which supports `auto` keyword. Also I found there are three files conflicting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org