You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/08/02 01:05:44 UTC
[kudu-CR] [tablet] the row size is equal to schema size plus null bitmap size
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13985
Change subject: [tablet] the row size is equal to schema size plus null bitmap size
......................................................................
[tablet] the row size is equal to schema size plus null bitmap size
The DCHECK_EQ statement in debug mode is not true while there are
nullable columns in schema.
Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
---
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/tablet-test-util.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/13985/1
--
To view, visit http://gerrit.cloudera.org:8080/13985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
Gerrit-Change-Number: 13985
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] [tablet] the row size is equal to schema size plus null bitmap size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13985 )
Change subject: [tablet] the row size is equal to schema size plus null bitmap size
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
Gerrit-Change-Number: 13985
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 02 Aug 2019 03:00:14 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] the row size is equal to schema size plus null bitmap size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13985 )
Change subject: [tablet] the row size is equal to schema size plus null bitmap size
......................................................................
[tablet] the row size is equal to schema size plus null bitmap size
The DCHECK_EQ statement in debug mode is not true while there are
nullable columns in schema.
Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
Reviewed-on: http://gerrit.cloudera.org:8080/13985
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/tablet-test-util.h
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
Gerrit-Change-Number: 13985
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)