You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/19 17:37:00 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5803: syslog: Change g_syslog_default_sem to static function variable
xiaoxiang781216 opened a new pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803
## Summary
## Impact
No, code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5803: syslog: Change g_syslog_default_sem to static function variable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803#discussion_r830574364
##########
File path: drivers/syslog/syslog_channel.c
##########
@@ -184,6 +180,7 @@ static ssize_t syslog_default_write(FAR struct syslog_channel_s *channel,
FAR const char *buffer, size_t buflen)
{
#if defined(CONFIG_ARCH_LOWPUTC)
+ static sem_t g_syslog_default_sem = SEM_INITIALIZER(1);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5803: syslog: Change g_syslog_default_sem to static function variable
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5803: syslog: Change g_syslog_default_sem to static function variable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803#issuecomment-1073192040
> Please remove Gerrit change-id
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5803: syslog: Change g_syslog_default_sem to static function variable
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803#discussion_r830510753
##########
File path: drivers/syslog/syslog_channel.c
##########
@@ -184,6 +180,7 @@ static ssize_t syslog_default_write(FAR struct syslog_channel_s *channel,
FAR const char *buffer, size_t buflen)
{
#if defined(CONFIG_ARCH_LOWPUTC)
+ static sem_t g_syslog_default_sem = SEM_INITIALIZER(1);
Review comment:
```suggestion
static sem_t default_sem = SEM_INITIALIZER(1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5803: syslog: Change g_syslog_default_sem to static function variable
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5803:
URL: https://github.com/apache/incubator-nuttx/pull/5803#issuecomment-1073175668
Please remove Gerrit change-id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org