You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/02/12 07:59:57 UTC

[jira] Created: (DERBY-5033) [patch] System.arraycopy, being native, is more performant

[patch] System.arraycopy, being native, is more performant
----------------------------------------------------------

                 Key: DERBY-5033
                 URL: https://issues.apache.org/jira/browse/DERBY-5033
             Project: Derby
          Issue Type: Improvement
          Components: Network Client
    Affects Versions: 10.7.1.1
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 10.8.0.0
         Attachments: use_arraycopy.diff

various places in the code, manual loops are used to copy one array to another, switch with System.arraycopy for better performance.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (DERBY-5033) [patch] System.arraycopy, being native, is more performant

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-5033.
---------------------------------------

          Resolution: Fixed
            Assignee: Dave Brosius
    Issue & fix info:   (was: [Patch Available])

Regression tests passed. Committed revision 1070677.

> [patch] System.arraycopy, being native, is more performant
> ----------------------------------------------------------
>
>                 Key: DERBY-5033
>                 URL: https://issues.apache.org/jira/browse/DERBY-5033
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: use_arraycopy.diff, use_arraycopy_2.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> various places in the code, manual loops are used to copy one array to another, switch with System.arraycopy for better performance.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DERBY-5033) [patch] System.arraycopy, being native, is more performant

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius closed DERBY-5033.
-------------------------------

    Bug behavior facts: [Performance]

> [patch] System.arraycopy, being native, is more performant
> ----------------------------------------------------------
>
>                 Key: DERBY-5033
>                 URL: https://issues.apache.org/jira/browse/DERBY-5033
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: use_arraycopy.diff, use_arraycopy_2.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> various places in the code, manual loops are used to copy one array to another, switch with System.arraycopy for better performance.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-5033) [patch] System.arraycopy, being native, is more performant

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5033:
--------------------------------------

    Attachment: use_arraycopy_2.diff

Thanks, Dave. This looks like a good simplification of the code. One of the arraycopy() calls in DecryptionManager was added without removing the corresponding loop. Attaching an updated patch (use_arraycopy_2.diff) that also removes the loop.

Running regression tests now.

> [patch] System.arraycopy, being native, is more performant
> ----------------------------------------------------------
>
>                 Key: DERBY-5033
>                 URL: https://issues.apache.org/jira/browse/DERBY-5033
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: use_arraycopy.diff, use_arraycopy_2.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> various places in the code, manual loops are used to copy one array to another, switch with System.arraycopy for better performance.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira