You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/09/17 19:21:32 UTC
[jira] Created: (HBASE-3012) TOF doesn't take zk client port for
remote clusters
TOF doesn't take zk client port for remote clusters
---------------------------------------------------
Key: HBASE-3012
URL: https://issues.apache.org/jira/browse/HBASE-3012
Project: HBase
Issue Type: Bug
Reporter: Jean-Daniel Cryans
Priority: Minor
Fix For: 0.90.0
Currently we are only able to specify the ZK ensemble and root znode for the remote cluster in TOF, we should also be able to give the client port (like in replication). This will require a change in CopyTable's command line arguments too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3012) TOF doesn't take zk client port for
remote clusters
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924104#action_12924104 ]
HBase Review Board commented on HBASE-3012:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jd...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1077/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Does exactly what this jira is about, and refactors all the cluster key processing into ZKUtil.
This addresses bug HBASE-3012.
http://issues.apache.org/jira/browse/HBASE-3012
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java 1026525
/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java 1026525
/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java 1026525
/trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java 1026525
/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1026525
Diff: http://review.cloudera.org/r/1077/diff
Testing
-------
Thanks,
Jean-Daniel
> TOF doesn't take zk client port for remote clusters
> ---------------------------------------------------
>
> Key: HBASE-3012
> URL: https://issues.apache.org/jira/browse/HBASE-3012
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.90.0
>
>
> Currently we are only able to specify the ZK ensemble and root znode for the remote cluster in TOF, we should also be able to give the client port (like in replication). This will require a change in CopyTable's command line arguments too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-3012) TOF doesn't take zk client port for
remote clusters
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-3012:
----------------------------
Assignee: Jean-Daniel Cryans
> TOF doesn't take zk client port for remote clusters
> ---------------------------------------------------
>
> Key: HBASE-3012
> URL: https://issues.apache.org/jira/browse/HBASE-3012
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.90.0
>
>
> Currently we are only able to specify the ZK ensemble and root znode for the remote cluster in TOF, we should also be able to give the client port (like in replication). This will require a change in CopyTable's command line arguments too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3012) TOF doesn't take zk client port for
remote clusters
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924140#action_12924140 ]
HBase Review Board commented on HBASE-3012:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1077/#review1633
-----------------------------------------------------------
Looks great J-D but no +1 until you've added a unit test that proves your parse stuff in ZKUtil does the right thing when single ensemble member, many ensemble members, empty port spec., etc. (No need to post the patch with unit test -- just commit)
/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
<http://review.cloudera.org/r/1077/#comment5492>
Minor spacing issue here?
- stack
> TOF doesn't take zk client port for remote clusters
> ---------------------------------------------------
>
> Key: HBASE-3012
> URL: https://issues.apache.org/jira/browse/HBASE-3012
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.90.0
>
>
> Currently we are only able to specify the ZK ensemble and root znode for the remote cluster in TOF, we should also be able to give the client port (like in replication). This will require a change in CopyTable's command line arguments too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3012) TOF doesn't take zk client port for
remote clusters
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-3012.
---------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to trunk with a new test in TestZooKeeper.
> TOF doesn't take zk client port for remote clusters
> ---------------------------------------------------
>
> Key: HBASE-3012
> URL: https://issues.apache.org/jira/browse/HBASE-3012
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.90.0
>
>
> Currently we are only able to specify the ZK ensemble and root znode for the remote cluster in TOF, we should also be able to give the client port (like in replication). This will require a change in CopyTable's command line arguments too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.