[GitHub] [james-project] ottoka commented on a change in pull request #748: JAMES-3670 : Configurable restore location for deleted messages

[GitBox <gi...@apache.org>]

ottoka commented on a change in pull request #748:
URL: https://github.com/apache/james-project/pull/748#discussion_r749303828



##########
File path: server/protocols/webadmin/webadmin-mailbox-deleted-message-vault/src/test/java/org/apache/james/webadmin/vault/routes/DeletedMessagesVaultRoutesTest.java
##########
@@ -198,7 +199,7 @@ void beforeEach() throws Exception {
         taskManager = new MemoryTaskManager(new Hostname("foo"));
         JsonTransformer jsonTransformer = new JsonTransformer();
 
-        RestoreService vaultRestore = new RestoreService(vault, mailboxManager);
+        RestoreService vaultRestore = new RestoreService(vault, mailboxManager, RestoreLocationConfiguration.DEFAULT);

Review comment:
       I was keeping them separate since they are used in different locations in the code base. And initially did not want to introduce more change impact than necessary, while it all was a private patch. But of course I can merge it all together now, which will also eliminate the extra module you commented on above.

##########
File path: server/container/guice/mailbox-plugin-deleted-messages-vault/src/main/java/org/apache/james/modules/vault/DeletedMessageVaultModule.java
##########
@@ -30,6 +30,7 @@
     @Override
     protected void configure() {
         install(new DeletedMessageVaultRetentionModule());
+        install(new DeletedMessagesVaultRestoreModule());

Review comment:
       Less change impact / smaller diff set originally, but see below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org