[GitHub] [arrow] lidavidm commented on a change in pull request #11739: ARROW-14769: [Go] Ensure MessageReader errors get reported

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #11739:
URL: https://github.com/apache/arrow/pull/11739#discussion_r752476436



##########
File path: go/arrow/ipc/reader.go
##########
@@ -196,7 +196,9 @@ func (r *Reader) Read() (array.Record, error) {
 	}
 
 	if !r.next() {
-		if r.done {
+		if r.err != nil {
+			return nil, r.err
+		} else if r.done {
 			return nil, io.EOF
 		}
 		return nil, r.err

Review comment:
       The problem is `next()` sets both `done` and `err`, so this will still return `io.EOF` instead of the actual error.
   
   https://github.com/apache/arrow/blob/c9495abbd0ad36575714808c563599c498969087/go/arrow/ipc/reader.go#L163-L167




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org