[GitHub] dongjoon-hyun commented on a change in pull request #23873: [SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23873: [SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition
URL: https://github.com/apache/spark/pull/23873#discussion_r261768034
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -651,6 +651,10 @@ object ColumnPruning extends Rule[LogicalPlan] {
     // Can't prune the columns on LeafNode
     case p @ Project(_, _: LeafNode) => p
 
+    case p @ NestedColumnPruning(prunedNestedAttrs, projectsOnPrunedNestedAttrs)
 
 Review comment:
   Oh, I missed to answer here, @maropu . This should be here before [line 660](https://github.com/apache/spark/pull/23873/files#diff-a636a87d8843eeccca90140be91d4fafR660). Otherwise, the projection is already moved down as the whole attribute instead of a subset of fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org