[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1495714369

   > I don't quite see how the general silencing and the @nowarn and @unchecked annotation changes play together here. Can we find a way to silence exactly the deprecation warnings we are concerned about and only in that submodule?
   
   @jrudolph So the changes here were copied from my work in Scala 3.3 (see https://github.com/apache/incubator-pekko/pull/270) because it turns out all of the Scala 3 specific changes done in the Scala 3.3 PR due to Scala 3 changes was actually add in Scala 3.2 (which this PR is updating to).
   
   With the deprecation warnings, there was a lot of places that Scala 3.2/3.3 was warning about deprecation so at least in my Scala 3.3 PR I made the decision to add the flag in order to reduce noise. While it was possible to use the `@nowarn` flag to silence the deprecation, these deprecation warnings was being generated in code that is being shared between Scala 2 and Scala 3 which means that if we were to use the `@nowarn` flag we would have to do changes to the Scala 2 compiler flags in order to not complain if no warnings were silenced (latest versions of Scala 2.12/2.13 will generate a warning if you use a `@nowarn` annotation that doesn't actually suppress anything, and iirc these deprecations  warnings are Scala 3.2/3.3 specific and don't occur in Scala 2.12/2.13)
   
   Regarding `@unchecked`, this seems to be due to an improvement that landed in Scala 3.2 which improves the exhaustiveness checking for pattern matching cases. Originally in my Scala 3.3 PR I tried to find a flag which covers only these new cases that require `@unchecked` so it can be silenced but it appears that the change in Scala 3.2 is extending an already existing case of exhaustiveness checking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org