You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 13:44:16 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #9819: Import Iterable from collections.abc in firestore operators

mik-laj commented on a change in pull request #9819:
URL: https://github.com/apache/airflow/pull/9819#discussion_r454366178



##########
File path: airflow/providers/google/firebase/operators/firestore.py
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from collections import Iterable
+from collections.abc import Iterable

Review comment:
       It seems to me that here it will be better to use typing.Iterable. We only use it in types, not to create our own class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org