You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/15 20:24:18 UTC

[GitHub] [superset] robdiciuccio commented on a change in pull request #15157: feat: Synchronously return cached charts

robdiciuccio commented on a change in pull request #15157:
URL: https://github.com/apache/superset/pull/15157#discussion_r652124572



##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -395,7 +395,16 @@ export function exploreJSON(
         if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) {
           // deal with getChartDataRequest transforming the response data
           const result = 'result' in response ? response.result[0] : response;
-          return waitForAsyncData(result);
+          const awaitingChartData =
+            'job_id' in result && 'channel_id' in result;

Review comment:
       Can we switch on HTTP status code instead here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org