You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/04/08 23:22:35 UTC

git commit: WICKET-5121 Log warning message if a component that is not on the page associated with the AjaxRequestTarget is added

Updated Branches:
  refs/heads/master 640cd630c -> ab9cf9445


WICKET-5121 Log warning message if a component that is not on the page associated with the AjaxRequestTarget is added


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ab9cf944
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ab9cf944
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ab9cf944

Branch: refs/heads/master
Commit: ab9cf94455ef21f3ed1d3580086cca35bfad64bd
Parents: 640cd63
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Apr 9 00:22:15 2013 +0300
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Apr 9 00:22:15 2013 +0300

----------------------------------------------------------------------
 .../apache/wicket/ajax/AbstractAjaxResponse.java   |    1 -
 .../org/apache/wicket/ajax/XmlAjaxResponse.java    |    4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/ab9cf944/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
index 1e3cd1a..a183ef4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
@@ -206,7 +206,6 @@ public abstract class AbstractAjaxResponse
 		for (Map.Entry<String, Component> stringComponentEntry : markupIdToComponent.entrySet())
 		{
 			final Component component = stringComponentEntry.getValue();
-			// final String markupId = stringComponentEntry.getKey();
 
 			if (!containsAncestorFor(component))
 			{

http://git-wip-us.apache.org/repos/asf/wicket/blob/ab9cf944/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java b/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
index 29a008f..9442cb3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
@@ -92,8 +92,8 @@ public abstract class XmlAjaxResponse extends AbstractAjaxResponse
 		{
 			// dont throw an exception but just ignore this component, somehow
 			// it got removed from the page.
-			LOG.debug("component: " + component + " with markupid: " + markupId +
-					" not rendered because it was already removed from page");
+			LOG.warn("Component '{}' with markupid: '{}' not rendered because it was already removed from page",
+					component, markupId);
 			return;
 		}