[GitHub] [couchdb] wohali commented on a change in pull request #2648: Feature - Add JWT support

[GitBox <gi...@apache.org>]

wohali commented on a change in pull request #2648: Feature - Add JWT support
URL: https://github.com/apache/couchdb/pull/2648#discussion_r390068836
 
 

 ##########
 File path: rel/overlay/etc/default.ini
 ##########
 @@ -131,7 +131,7 @@ prefer_minimal = Cache-Control, Content-Length, Content-Range, Content-Type, ETa
 max_db_number_for_dbs_info_req = 100
 
 ; authentication handlers
-; authentication_handlers = {chttpd_auth, cookie_authentication_handler}, {chttpd_auth, default_authentication_handler}
+authentication_handlers = {chttpd_auth, jwt_authentication_handler}, {chttpd_auth, cookie_authentication_handler}, {chttpd_auth, default_authentication_handler}
 
 Review comment:
   The `default.ini` file is intended to document defaults. The line here should remain commented out.
   
   If we add JWT support as enabled out of the box, as you propose, you'd update L134 to include the new default, but you would also change the definition of the default in Erlang at https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd.erl#L491-L492 .
   
   If we don't add JWT support as enabled by default, you could add a new example line here similar to the one at line 136.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services