You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/12/30 08:57:20 UTC
[31/50] [abbrv] kylin git commit: minor,
fix could not parse issue for scheduler
minor, fix could not parse issue for scheduler
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/08eda7b7
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/08eda7b7
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/08eda7b7
Branch: refs/heads/master-cdh5.7
Commit: 08eda7b714a30c665bdd777c296d15c7650c9ea9
Parents: fd745c8
Author: Billy Liu <bi...@apache.org>
Authored: Wed Dec 28 19:00:00 2016 +0800
Committer: Billy Liu <bi...@apache.org>
Committed: Wed Dec 28 22:01:39 2016 +0800
----------------------------------------------------------------------
.../kylin/job/impl/threadpool/DefaultScheduler.java | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/08eda7b7/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
index be8e7fe..ddb3a21 100644
--- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
+++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
@@ -105,15 +105,18 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
continue;
}
nReady++;
- AbstractExecutable executable = executableManager.getJob(id);
- String jobDesc = executable.toString();
- logger.info(jobDesc + " prepare to schedule");
+ AbstractExecutable executable = null;
+ String jobDesc = null;
try {
+ executable = executableManager.getJob(id);
+ jobDesc = executable.toString();
+ logger.info(jobDesc + " prepare to schedule");
context.addRunningJob(executable);
jobPool.execute(new JobRunner(executable));
logger.info(jobDesc + " scheduled");
} catch (Exception ex) {
- context.removeRunningJob(executable);
+ if (executable != null)
+ context.removeRunningJob(executable);
logger.warn(jobDesc + " fail to schedule", ex);
}
}