You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/04/19 04:06:40 UTC

[jira] [Created] (FLUME-1132) HDFSEventSink has spurious and verbose log message

HDFSEventSink has spurious and verbose log message
--------------------------------------------------

                 Key: FLUME-1132
                 URL: https://issues.apache.org/jira/browse/FLUME-1132
             Project: Flume
          Issue Type: Improvement
            Reporter: Brock Noland


The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266264#comment-13266264 ] 

jiraposter@reviews.apache.org commented on FLUME-1132:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4838/#review7457
-----------------------------------------------------------

Ship it!


+1 Changes look good. A couple of nits noted below.


flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/4838/#comment16464>

    nit: the callWithTimeoutLogError adds a prefix to the log message as "Error calling " + name. This translates to a message in this case like:"Error calling Calling flush on ...".  Suggest removing the redundant words here and keeping the name to "flush on " + callableWriter.



flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
<https://reviews.apache.org/r/4838/#comment16465>

    nit: "close on " + e.getKey()


- Arvind


On 2012-04-22 23:17:45, Brock Noland wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4838/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-22 23:17:45)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Message is logged a large volume of times and is incorrect.
bq.  
bq.  
bq.  This addresses bug FLUME-1132.
bq.      https://issues.apache.org/jira/browse/FLUME-1132
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad 
bq.  
bq.  Diff: https://reviews.apache.org/r/4838/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Logging only change
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Brock
bq.  
bq.


                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266962#comment-13266962 ] 

Hudson commented on FLUME-1132:
-------------------------------

Integrated in flume-trunk #192 (See [https://builds.apache.org/job/flume-trunk/192/])
    FLUME-1132. HDFS Event Sink has spurious and verbose log message.

(Brock Noland via Arvind Prabhakar) (Revision 1333223)

     Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1333223
Files : 
* /incubator/flume/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java

                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1132-0.patch, FLUME-1132-1.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1132:
------------------------------------

       Resolution: Fixed
    Fix Version/s: v1.2.0
           Status: Resolved  (was: Patch Available)

Patch committed. Thanks Brock!
                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1132-0.patch, FLUME-1132-1.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland reassigned FLUME-1132:
-----------------------------------

    Assignee: Brock Noland
    
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-1132:
--------------------------------

    Attachment: FLUME-1132-1.patch

Patch from RB
                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1132-0.patch, FLUME-1132-1.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-1132:
--------------------------------

    Attachment: FLUME-1132-0.patch

Patch from RB
                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-1132:
--------------------------------

    Affects Version/s:     (was: v1.2.0)
                       v1.1.0
    
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259296#comment-13259296 ] 

jiraposter@reviews.apache.org commented on FLUME-1132:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4838/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Message is logged a large volume of times and is incorrect.


This addresses bug FLUME-1132.
    https://issues.apache.org/jira/browse/FLUME-1132


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad 

Diff: https://reviews.apache.org/r/4838/diff


Testing
-------

Logging only change


Thanks,

Brock


                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266650#comment-13266650 ] 

jiraposter@reviews.apache.org commented on FLUME-1132:
------------------------------------------------------



bq.  On 2012-05-02 00:20:27, Arvind Prabhakar wrote:
bq.  > +1 Changes look good. A couple of nits noted below.

Resolve both nits and attached to JIRA. Thank you for your review!


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4838/#review7457
-----------------------------------------------------------


On 2012-04-22 23:17:45, Brock Noland wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4838/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-22 23:17:45)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Message is logged a large volume of times and is incorrect.
bq.  
bq.  
bq.  This addresses bug FLUME-1132.
bq.      https://issues.apache.org/jira/browse/FLUME-1132
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad 
bq.  
bq.  Diff: https://reviews.apache.org/r/4838/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Logging only change
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Brock
bq.  
bq.


                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1132-0.patch, FLUME-1132-1.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-1132:
--------------------------------

    Affects Version/s: v1.2.0
    
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1132) HDFSEventSink has spurious and verbose log message

Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-1132:
--------------------------------

    Status: Patch Available  (was: Open)
    
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1132-0.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira