You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "hemasrishalini (via GitHub)" <gi...@apache.org> on 2026/06/07 18:40:54 UTC

[PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

hemasrishalini opened a new pull request, #4637:
URL: https://github.com/apache/polaris/pull/4637

   ## Summary
   
   Adds unit test coverage for `OAuthUtils#getResponseFromError`.
   
   ### Changes
   
   * Verifies response status mapping for all `OAuthError` values
   * Covers the `unauthorized_client` → `401 UNAUTHORIZED` mapping
   * Verifies `400 BAD_REQUEST` mappings for:
   
     * `invalid_client`
     * `invalid_grant`
     * `unsupported_grant_type`
     * `invalid_scope`
   * Covers the default branch using `invalid_request`
   * Verifies that the returned `OAuthTokenErrorResponse` contains the expected error value
   
   ### Testing
   
   ```bash
   ./gradlew :polaris-runtime-service:test --tests "org.apache.polaris.service.auth.internal.service.OAuthUtilsTest"
   ```
   
   BUILD SUCCESSFUL
   
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #4637: Add test coverage for OAuthUtils OAuthError mappings
URL: https://github.com/apache/polaris/pull/4637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

Posted by "hemasrishalini (via GitHub)" <gi...@apache.org>.

hemasrishalini commented on PR #4637:
URL: https://github.com/apache/polaris/pull/4637#issuecomment-4656964158

   Thanks for the review and feedback!
   
   My intention was to improve coverage around the OAuth error-to-response mapping, including the default branch and validation of the returned error response.
   
   I understand the concern that the test closely mirrors the implementation and may provide limited value given the simplicity of the mapping logic. I'm happy to defer to the maintainers' judgment on whether this coverage is worthwhile to keep.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #4637:
URL: https://github.com/apache/polaris/pull/4637#issuecomment-4964747483

   This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.

dimas-b commented on code in PR #4637:
URL: https://github.com/apache/polaris/pull/4637#discussion_r3377859030


##########
runtime/service/src/test/java/org/apache/polaris/service/auth/internal/service/OAuthUtilsTest.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.auth.internal.service;
+
+import jakarta.ws.rs.core.Response;
+import org.assertj.core.api.Assertions;
+import org.assertj.core.api.InstanceOfAssertFactories;
+import org.junit.jupiter.api.Test;
+
+class OAuthUtilsTest {
+
+  @Test
+  void testUnauthorizedClientResponse() {
+    Response response = OAuthUtils.getResponseFromError(OAuthError.unauthorized_client);
+
+    Assertions.assertThat(response.getStatus())
+        .isEqualTo(Response.Status.UNAUTHORIZED.getStatusCode());
+
+    Assertions.assertThat(response.getEntity())
+        .isInstanceOf(OAuthTokenErrorResponse.class)
+        .asInstanceOf(InstanceOfAssertFactories.type(OAuthTokenErrorResponse.class))
+        .returns(OAuthError.unauthorized_client.name(), OAuthTokenErrorResponse::getError);
+  }
+
+  @Test
+  void testInvalidClientResponse() {
+    assertBadRequest(OAuthError.invalid_client);

Review Comment:
   The code under test is linear. Adding this unit test is mostly equivalent to a review of the original code.
   
   When changes are made, the adjustments in this test and in the "prod" code are going to be logically equivalent... All in all, the value of this test does not appear to be high, IMHO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add test coverage for OAuthUtils OAuthError mappings [polaris]

Posted by "hemasrishalini (via GitHub)" <gi...@apache.org>.

hemasrishalini commented on code in PR #4637:
URL: https://github.com/apache/polaris/pull/4637#discussion_r3407565366


##########
runtime/service/src/test/java/org/apache/polaris/service/auth/internal/service/OAuthUtilsTest.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.auth.internal.service;
+
+import jakarta.ws.rs.core.Response;
+import org.assertj.core.api.Assertions;
+import org.assertj.core.api.InstanceOfAssertFactories;
+import org.junit.jupiter.api.Test;
+
+class OAuthUtilsTest {
+
+  @Test
+  void testUnauthorizedClientResponse() {
+    Response response = OAuthUtils.getResponseFromError(OAuthError.unauthorized_client);
+
+    Assertions.assertThat(response.getStatus())
+        .isEqualTo(Response.Status.UNAUTHORIZED.getStatusCode());
+
+    Assertions.assertThat(response.getEntity())
+        .isInstanceOf(OAuthTokenErrorResponse.class)
+        .asInstanceOf(InstanceOfAssertFactories.type(OAuthTokenErrorResponse.class))
+        .returns(OAuthError.unauthorized_client.name(), OAuthTokenErrorResponse::getError);
+  }
+
+  @Test
+  void testInvalidClientResponse() {
+    assertBadRequest(OAuthError.invalid_client);

Review Comment:
   @dimas-b Thanks for the review and feedback!
   
   My intention was to improve coverage around the OAuth error to response mapping, including the default branch and validation of the returned error response.
   
   I understand the concern that the test closely mirrors the implementation and may provide limited value given the simplicity of the mapping logic. I'm happy to defer to the maintainers' judgment on whether this coverage is worthwhile to keep.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org