You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/11/22 13:32:52 UTC
[GitHub] zeppelin pull request #1669: HOT FIX: Fix NPE while getting default interpre...
GitHub user r-kamath opened a pull request:
https://github.com/apache/zeppelin/pull/1669
HOT FIX: Fix NPE while getting default interpreter setting
### What is this PR for?
NPE while starting Zeppelin for the first time without interpreter settings
### What type of PR is it?
Hot Fix
### What is the Jira issue?
n/a
### How should this be tested?
remove conf/interpreter.json and start Zeppelin
### Logs
**Before**
`
java.lang.NullPointerException
at org.apache.zeppelin.interpreter.InterpreterFactory.getEditorSetting(InterpreterFactory.java:1385)
at org.apache.zeppelin.socket.NotebookServer.getEditorSetting(NotebookServer.java:1796)
at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:290)
at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
`
**After**
`
WARN [2016-11-22 18:52:16,890] ({qtp1702660825-60} InterpreterFactory.java[getEditorSetting]:1405) - Couldn't get interpreter editor setting
`
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin npe-interpreter-setting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1669.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1669
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1669: HOT FIX: Fix NPE while getting default interpreter set...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1669
Test failed, but not irrelevant with this PR
```
// https://travis-ci.org/apache/zeppelin/jobs/177967999
// https://api.travis-ci.org/jobs/177967999/log.txt?deansi=true
14:40:57,230 INFO org.apache.zeppelin.ZeppelinITUtils:41 - Finished.
14:40:57,230 INFO org.apache.zeppelin.integration.ZeppelinIT:189 - testCreateNotebook Test executed
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 113.057 sec - in org.apache.zeppelin.integration.ZeppelinIT
Results :
Tests in error:
ParagraphActionsIT.testClearOutputButton:278->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 � Timeout
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1669: HOT FIX: Fix NPE while getting default interpre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1669
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1669: HOT FIX: Fix NPE while getting default interpreter set...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1669
LGTM and merge to master as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1669: HOT FIX: Fix NPE while getting default interpreter set...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1669
I've seen it quite a few times. thanks for the fix, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---