You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/07 11:22:00 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2220: HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict
adoroszlai opened a new pull request #2220:
URL: https://github.com/apache/ozone/pull/2220
## What changes were proposed in this pull request?
The name of volume created in `testListBucketsOnEmptyVolume` or `testListKeyOnEmptyBucket` might contain the prefix used in `testListVolume`:
```
... Creating Volume: vol-71454, ...
...
... Creating Volume: vol-714-a-0-78727, ...
```
which leads to unexpected number of volumes with that prefix:
```
Tests run: 80, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 175.065 s <<< FAILURE! - in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClient
testListVolume Time elapsed: 0.086 s <<< FAILURE!
java.lang.AssertionError: expected:<20> but was:<21>
...
at org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClientAbstract.testListVolume(TestOzoneRpcClientAbstract.java:1867)
```
This fix simply changes to fix volume name for `testListBucketsOnEmptyVolume` and a different fix prefix for `testListVolume`, thus avoiding conflict.
https://issues.apache.org/jira/browse/HDDS-5192
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/2521726183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2220: HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2220:
URL: https://github.com/apache/ozone/pull/2220#issuecomment-836139771
Thank You @adoroszlai for the fix and @ayushtkn for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2220: HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2220:
URL: https://github.com/apache/ozone/pull/2220#issuecomment-836251294
Thanks @ayushtkn and @bharatviswa504 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2220: HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2220:
URL: https://github.com/apache/ozone/pull/2220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2220: HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2220:
URL: https://github.com/apache/ozone/pull/2220#discussion_r628786584
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -1845,7 +1845,7 @@ public void testKeysRenameFail() throws Exception {
@Test
public void testListVolume() throws IOException {
- String volBase = "vol-" + RandomStringUtils.randomNumeric(3);
+ String volBase = "vol-list-";
Review comment:
Can you update the comment below as well
``
//Create 10 volume vol-<random>-a-0-<random> to vol-<random>-a-9-<random>
``
to denote the change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org