You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/06/23 16:35:02 UTC
[GitHub] [hadoop] steveloughran commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call
steveloughran commented on code in PR #4248:
URL: https://github.com/apache/hadoop/pull/4248#discussion_r905241976
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java:
##########
@@ -570,8 +570,14 @@ public void setStatus(String status) {
*/
@SuppressWarnings("unchecked")
public void close() throws IOException, InterruptedException {
- for (RecordWriter writer : recordWriters.values()) {
- writer.close(context);
- }
+ recordWriters.values().parallelStream().forEach(writer -> {
Review Comment:
this is probably true. looking at IOUtils, our own cleanupWithLogger() method catches all throwables, but closeSocket() only swallows IOEs. We must assume a lot of other code is similar, so raised IOEs must stay as IOEs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org