You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 03:00:27 UTC
[I] [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain [shenyu]
Aias00 opened a new issue, #6889:
URL: https://github.com/apache/shenyu/issues/6889
## Description
The CONNACK session-present flag is hard-coded `true` for every connection, including the very first connect and clients with the clean-session flag set. Combined with the complete absence of session-state persistence (`Disconnect.cleanChannel` only touches `ChannelRepository`; `Disconnect.java:39` carries `// todo Clean session`), the broker actively lies about stored session state.
## Location
- `shenyu-protocol/shenyu-protocol-mqtt/src/main/java/org/apache/shenyu/protocol/mqtt/Connect.java:72`
## Impact
Violates MQTT-3.2.2-6/7. A client reconnecting with `cleanSession=1` is told a session was present (must be `0`); a first-time client is told the same.
## Suggested fix
Set `sessionPresent` from the connect-flags `cleanSession` bit and stored session state (false when `cleanSession=1` or no prior session).
## Related existing
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain [shenyu]
Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #6889:
URL: https://github.com/apache/shenyu/issues/6889#issuecomment-5935472603
Triage note: the current title says “MCP tool-call timeout”, but the issue body describes the MQTT CONNACK `sessionPresent`/clean-session bug. The body matches the work in [PR #6894](https://github.com/apache/shenyu/pull/6894), which is still open. The MCP timeout behavior described by the title is already implemented and regression-tested by merged [PR #6937](https://github.com/apache/shenyu/pull/6937) (its description references #6888, whose current title is about JsonSchemaUtil). It looks like the titles for #6888 and #6889 may have been crossed. Could a maintainer correct the titles/issue links so contributors can track the two fixes accurately? I am not starting another implementation while #6894 is active.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6889:
URL: https://github.com/apache/shenyu/issues/6889#issuecomment-5174097081
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain
- **Link**: https://github.com/apache/shenyu/issues/6889
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6889: [BUG] MCP tool-call timeout does not cancel the in-flight plugin chain
URL: https://github.com/apache/shenyu/issues/6889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org