You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sreekanth Ramakrishnan <sr...@gmail.com> on 2014/12/01 10:43:24 UTC
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 9:43 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Repository: lens
Description
-------
Moving Mock classes to test package in server-api module
Diffs (updated)
-----
lens-cli/pom.xml 03b12ab
lens-cube/pom.xml 2a461d1
lens-driver-hive/pom.xml f030251
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 6763e2e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java c4d6b6d
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
lens-server/pom.xml 9a8fb7d
Diff: https://reviews.apache.org/r/28546/diff/
Testing
-------
Thanks,
Sreekanth Ramakrishnan
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Sreekanth Ramakrishnan <sr...@gmail.com>.
I have closed my older review request.
On Thu, Dec 18, 2014 at 10:18 AM, Amareshwari Sriramadasu <
amareshwari@apache.org> wrote:
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28546/
>
> On December 15th, 2014, 11:23 a.m. UTC, *Raju Bairishetti* wrote:
>
> Raised a new review request at https://reviews.apache.org/r/29048/
>
> @Sreekanth, Can you discard this review request in favor of the other one?
>
>
> - Amareshwari
>
> On December 1st, 2014, 9:57 a.m. UTC, Sreekanth Ramakrishnan wrote:
> Review request for lens and Amareshwari Sriramadasu.
> By Sreekanth Ramakrishnan.
>
> *Updated Dec. 1, 2014, 9:57 a.m.*
> *Bugs: * lens-82 <https://issues.apache.org/jira/browse/lens-82>
> *Repository: * lens
> Description
>
> Moving Mock classes to test package in server-api module
>
> Diffs
>
> - lens-cli/pom.xml (03b12ab)
> - lens-cube/pom.xml (2a461d1)
> - lens-driver-hive/pom.xml (f030251)
> - lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java
> (833edc5)
> - lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java
> (3346701)
> - lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java
> (7c31338)
> - lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
> (PRE-CREATION)
> - lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java
> (PRE-CREATION)
> - lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java
> (PRE-CREATION)
> - lens-server/pom.xml (9a8fb7d)
>
> View Diff <https://reviews.apache.org/r/28546/diff/>
>
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 15, 2014, 11:23 a.m., Raju Bairishetti wrote:
> > Raised a new review request at https://reviews.apache.org/r/29048/
@Sreekanth, Can you discard this review request in favor of the other one?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/#review65080
-----------------------------------------------------------
On Dec. 1, 2014, 9:57 a.m., Sreekanth Ramakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28546/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 9:57 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: lens-82
> https://issues.apache.org/jira/browse/lens-82
>
>
> Repository: lens
>
>
> Description
> -------
>
> Moving Mock classes to test package in server-api module
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 03b12ab
> lens-cube/pom.xml 2a461d1
> lens-driver-hive/pom.xml f030251
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
> lens-server/pom.xml 9a8fb7d
>
> Diff: https://reviews.apache.org/r/28546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sreekanth Ramakrishnan
>
>
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/#review65080
-----------------------------------------------------------
Raised a new review request at https://reviews.apache.org/r/29048/
- Raju Bairishetti
On Dec. 1, 2014, 9:57 a.m., Sreekanth Ramakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28546/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 9:57 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: lens-82
> https://issues.apache.org/jira/browse/lens-82
>
>
> Repository: lens
>
>
> Description
> -------
>
> Moving Mock classes to test package in server-api module
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 03b12ab
> lens-cube/pom.xml 2a461d1
> lens-driver-hive/pom.xml f030251
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
> lens-server/pom.xml 9a8fb7d
>
> Diff: https://reviews.apache.org/r/28546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sreekanth Ramakrishnan
>
>
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/#review64819
-----------------------------------------------------------
Sreekanth, Can you take care of https://issues.apache.org/jira/browse/LENS-82?focusedCommentId=14230995&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14230995 ?
- Amareshwari Sriramadasu
On Dec. 1, 2014, 9:57 a.m., Sreekanth Ramakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28546/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 9:57 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: lens-82
> https://issues.apache.org/jira/browse/lens-82
>
>
> Repository: lens
>
>
> Description
> -------
>
> Moving Mock classes to test package in server-api module
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 03b12ab
> lens-cube/pom.xml 2a461d1
> lens-driver-hive/pom.xml f030251
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
> lens-server/pom.xml 9a8fb7d
>
> Diff: https://reviews.apache.org/r/28546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sreekanth Ramakrishnan
>
>
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/#review63347
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 1, 2014, 9:57 a.m., Sreekanth Ramakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28546/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 9:57 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: lens-82
> https://issues.apache.org/jira/browse/lens-82
>
>
> Repository: lens
>
>
> Description
> -------
>
> Moving Mock classes to test package in server-api module
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 03b12ab
> lens-cube/pom.xml 2a461d1
> lens-driver-hive/pom.xml f030251
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
> lens-server/pom.xml 9a8fb7d
>
> Diff: https://reviews.apache.org/r/28546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sreekanth Ramakrishnan
>
>
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Sreekanth Ramakrishnan <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 9:57 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: lens-82
https://issues.apache.org/jira/browse/lens-82
Repository: lens
Description
-------
Moving Mock classes to test package in server-api module
Diffs
-----
lens-cli/pom.xml 03b12ab
lens-cube/pom.xml 2a461d1
lens-driver-hive/pom.xml f030251
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
lens-server/pom.xml 9a8fb7d
Diff: https://reviews.apache.org/r/28546/diff/
Testing
-------
Thanks,
Sreekanth Ramakrishnan
Re: Review Request 28546: Moving Mock classes to test package in
server-api module
Posted by Sreekanth Ramakrishnan <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28546/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 9:56 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Repository: lens
Description
-------
Moving Mock classes to test package in server-api module
Diffs (updated)
-----
lens-cli/pom.xml 03b12ab
lens-cube/pom.xml 2a461d1
lens-driver-hive/pom.xml f030251
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java 833edc5
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockFailDriver.java 3346701
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java 7c31338
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java PRE-CREATION
lens-server/pom.xml 9a8fb7d
Diff: https://reviews.apache.org/r/28546/diff/
Testing
-------
Thanks,
Sreekanth Ramakrishnan