You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "3pacccccc (via GitHub)" <gi...@apache.org> on 2025/07/25 19:15:00 UTC
[PR] [fix][broker]fix flaky-test ReplicatorTest.testCloseReplicatorStartProducer [pulsar]
3pacccccc opened a new pull request, #24567:
URL: https://github.com/apache/pulsar/pull/24567
Fixes https://github.com/apache/pulsar/issues/24566
### Verifying this change
- [x] Make sure that the change passes the CI checks.
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/3pacccccc/pulsar/pull/18
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker]fix flaky-test ReplicatorTest.testCloseReplicatorStartProducer [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24567:
URL: https://github.com/apache/pulsar/pull/24567#issuecomment-3120908112
@3pacccccc Thanks for the attempt in this PR. I'll close this PR. The test itself is bad besides a real bug. I have fixed the test and the underlying problem in #24569. Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker]fix flaky-test ReplicatorTest.testCloseReplicatorStartProducer [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #24567:
URL: https://github.com/apache/pulsar/pull/24567#discussion_r2231864447
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1088,6 +1089,11 @@ public DelayCheckForNewEntriesTask(OpReadEntry op, ReadEntriesCallback callback,
@Override
public void run() {
synchronized (pendingReadOpMutex) {
+ if (cancelled) {
+ // change state back to init in order to execute cancel()
+ state = DelayCheckForNewEntriesTaskState.INIT;
+ return;
+ }
Review Comment:
This seems to indicate that the original state model has some gaps. Could you explain more about your findings about the issue itself? Please also update the description of the PR with some more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker]fix flaky-test ReplicatorTest.testCloseReplicatorStartProducer [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #24567: [fix][broker]fix flaky-test ReplicatorTest.testCloseReplicatorStartProducer
URL: https://github.com/apache/pulsar/pull/24567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org