[GitHub] [arrow-datafusion] alamb commented on pull request #6607: Support internal cast for BuiltinScalarFunction::MakeArray

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #6607:
URL: https://github.com/apache/arrow-datafusion/pull/6607#issuecomment-1589396242

   > LGTM. If you have more time, you can add more sql logic tests.
   
   Specifically, I think adding coverage for NULL and arrays would be helpful:
   
   ```sql
   select make_array(null, 1.0)
   ```
   
   ```sql
   select make_array(1.0, '2', null)
   ```
   
   ```sql
   create table foo (x int, y double) as values (1, 2.0);
   select make_array(x, y) from foo;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org