You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/25 23:15:55 UTC
[GitHub] [incubator-tvm] comaniac opened a new pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
comaniac opened a new pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562
After #6391, we require `USE_RANDOM` to be on during the tuning. However, setting `USE_RANDOM ON` in `cmake/config.cmake` doesn't really turn it on by default.
cc @FrozenGene
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] FrozenGene commented on pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562#issuecomment-699212019
Thanks Cody. Could you explain a little bit why cmake/config.cmake doesn’t turn it on by default? As USE_SORT uses this way too------------------ Original ------------------From: Cody Yu <no...@github.com>Date: Sat,Sep 26,2020 7:16 AMTo: apache/incubator-tvm <in...@noreply.github.com>Cc: Zhao Wu <zh...@apache.org>, Mention <me...@noreply.github.com>Subject: Re: [apache/incubator-tvm] [AutoTVM][Ansor] Turn on USE_RANDOM by default (#6562)After #6391, we require USE_RANDOM to be on during the tuning. However, setting USE_RANDOM ON in cmake/config.cmake doesn't really turn it on by default.
cc @FrozenGene
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-tvm/pull/6562
Commit Summary
Turn on USE_RANDOM by default
File Changes
M
CMakeLists.txt
(2)
Patch Links:
https://github.com/apache/incubator-tvm/pull/6562.patch
https://github.com/apache/incubator-tvm/pull/6562.diff
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac edited a comment on pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
Posted by GitBox <gi...@apache.org>.
comaniac edited a comment on pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562#issuecomment-699213150
It's fine if users directly copy `cmake/config.cmake` to build. However, as the usage in the docker images, some users prefer to create a simple `config.cmake` that only overrides the values against CMakefile. In my personal case, my `config.cmake` doesn't have `USE_RANDOM` and I expected it to be ON by referring to `cmake/config.cmake`, but it doesn't work as expected, so does `USE_SORT`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562#issuecomment-699213150
It's fine if users directly copy `cmake/config.cmake` to build. However, as the usage in the docker images, some users prefer to create a simple `config.cmake` that only overrides the values against CMakefile. In my personal case, my `config.cmake` doesn't have `USE_RANDOM` and I expected it to be on by referring to `cmake/config.cmake`, but it doesn't work as expected, so does `USE_SORT`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] FrozenGene commented on pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562#issuecomment-699214733
ok. Thanks for explaining.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6562: [AutoTVM][Ansor] Turn on USE_RANDOM by default
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6562:
URL: https://github.com/apache/incubator-tvm/pull/6562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org