[jira] [Commented] (HBASE-5454) Refuse operations from Admin befor master is initialized

["stack (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214144#comment-13214144 ] 

stack commented on HBASE-5454:
------------------------------

This patch is a good idea Chunhui.

I don't think you need to have this message "Master is not initialized" on an exception whose type is: MasterNotInitializedException.  It seems redundant.

Remove this line:

+ * Copyright 2007 The Apache Software Foundation

Maybe you don't need these two methods?

+  public MasterNotInitializedException(String s) {
+    super(s);
+  }
+
+  /**
+   * Constructor taking another exception.
+   * 
+   * @param e Exception to grab data from.
+   */
+  public MasterNotInitializedException(Exception e) {


                
> Refuse operations from Admin befor master is initialized
> --------------------------------------------------------
>
>                 Key: HBASE-5454
>                 URL: https://issues.apache.org/jira/browse/HBASE-5454
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: chunhui shen
>         Attachments: hbase-5454.patch
>
>
> In our testing environment,
> When master is initializing, we found conflict problems between master#assignAllUserRegions and EnableTable event, causing assigning region throw exception so that master abort itself.
> We think we'd better refuse operations from Admin, such as CreateTable, EnableTable,etc, It could reduce error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira