You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/10/15 13:00:20 UTC
[GitHub] [incubator-echarts] pissang commented on a change in pull request
#11186: FIX #11176 xAxis.axisTick.interval appears different between
echart4 and echart3.8
pissang commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
URL: https://github.com/apache/incubator-echarts/pull/11186#discussion_r334935652
##########
File path: src/coord/Axis.js
##########
@@ -315,7 +320,10 @@ function fixOnBandTicksCoords(axis, ticksCoords, tickCategoryInterval, alignWith
ticksItem.coord -= shift / ((tickCategoryInterval + 1) * 2);
}
});
- last = {coord: ticksCoords[ticksLen - 1].coord + shift};
+
+ diffSize = tickLen - ticksCoords[ticksLen - 1].tickValue;
Review comment:
I think this should be
```js
diffSize = tickLen - crossLen;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org