You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2018/02/09 16:30:37 UTC
[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1862
ARTEMIS-1676 Support overriding of JAVA_ARGS via env variable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1862.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1862
----
commit 62d904f47979afae105981144053f30430ecd310
Author: Martyn Taylor <mt...@...>
Date: 2018-02-09T16:29:44Z
ARTEMIS-1676 Support overriding of JAVA_ARGS via env variable
----
---
[GitHub] activemq-artemis issue #1862: ARTEMIS-1676 Support overriding of JAVA_ARGS v...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1862
@mtaylor can you update the Windows artemis.profile.cmd, I can test it on Windows.
---
[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1862#discussion_r167639675
--- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile ---
@@ -21,14 +21,20 @@ ARTEMIS_INSTANCE='${artemis.instance}'
# The logging config will need an URI
# this will be encoded in case you use spaces or special characters
# on your directory structure
-ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
-# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
-#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
+if [ -z "$ARTEMIS_INSTANCE_URI" ]; then
+ ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
+fi
+# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
+if [ -z "$ARTEMIS_CLUSTER_PROPS" ]; then
+ #ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
--- End diff --
It is just keeping the same functionality but ensuring the priory isn't overridden when set. I left in the commented out property as an example
---
[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1862
---
[GitHub] activemq-artemis issue #1862: ARTEMIS-1676 Support overriding of JAVA_ARGS v...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1862
Yes it's possible. We would need to test it on a windows machine. That profile is actually structured differently
---
[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1862#discussion_r167280403
--- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile ---
@@ -21,14 +21,20 @@ ARTEMIS_INSTANCE='${artemis.instance}'
# The logging config will need an URI
# this will be encoded in case you use spaces or special characters
# on your directory structure
-ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
-# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
-#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
+if [ -z "$ARTEMIS_INSTANCE_URI" ]; then
+ ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
+fi
+# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
+if [ -z "$ARTEMIS_CLUSTER_PROPS" ]; then
+ #ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
--- End diff --
what's the point of adding this commented out? the user would have to add it anyways?
---
[GitHub] activemq-artemis issue #1862: ARTEMIS-1676 Support overriding of JAVA_ARGS v...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1862
closing will reopen with suggestions
---
[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1862#discussion_r173290483
--- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile ---
@@ -21,14 +21,20 @@ ARTEMIS_INSTANCE='${artemis.instance}'
# The logging config will need an URI
# this will be encoded in case you use spaces or special characters
# on your directory structure
-ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
-# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
-#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
+if [ -z "$ARTEMIS_INSTANCE_URI" ]; then
+ ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
+fi
+# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be referenced in broker.xml
+if [ -z "$ARTEMIS_CLUSTER_PROPS" ]; then
+ #ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446"
--- End diff --
I would be ok with this on ARTEMIS_HOME.. ARTEMIS_INSTANCE is a bit dangerous IMO.
Say you went to cd /artemis-servers/server1
and by accident previously you set ARTEMIS-INSTANCE = /artemis-server/myOtherServer
You wouldn't be able to figure out easily... I think it's a bit dangerous...
the best way we can do about this is like what we do now.. we figure out ARTEMIS-INSTANCE by the location of the executable's. if you do /my-other-server/bin/artemis start
then you will know you're starting the right server.
---
[GitHub] activemq-artemis issue #1862: ARTEMIS-1676 Support overriding of JAVA_ARGS v...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1862
I something similar possible for artemis.profile.cmd also?
---