You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/05 15:20:52 UTC

[GitHub] [superset] ktmud commented on pull request #19954: chore: convert URLShortLinkButton to typescript

ktmud commented on PR #19954:
URL: https://github.com/apache/superset/pull/19954#issuecomment-1118689254

   @villebro I made more changes to this PR:
   
   - Converted `AnchorLink` component to tsx, too
   - Moved both AnchorLink and URLShortLinkButton to `src/dashboards` since they really are dashboard only components.
   - Renamed `AnchorLinkProps["anchorLinkId"]` to `AnchorLinkProps["id"]`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org