You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/01/06 00:24:04 UTC

Review Request 29598: Moved Modules protobuf to mesos namespace.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

Review request for mesos, Niklas Nielsen and Till Toenshoff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs
-----

  include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review68804
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/29598/#comment113274>

    How about moving this to it's own .proto file?


- Niklas Nielsen


On Jan. 19, 2015, 2:52 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/10] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 859aa2fba2536b21dd2fe1f0baa2ae3417f63fdf 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:37 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Addressed Nik's comment. Moved modules.proto to mesos/module/


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module/module.hpp PRE-CREATION 
  include/mesos/module/module.proto PRE-CREATION 
  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/common/parse.hpp 772a1a5dbc2574977de6b931b1954e15cae99acb 
  src/common/type_utils.hpp 5c24c080f359a6adc4840f0a1586d21585616908 
  src/master/flags.hpp df2e9cbdd56e9831290bf57c65b212cd7820a7f6 
  src/messages/messages.proto 44122bd777a27236d3f4aad376e0055544d40121 
  src/module/manager.hpp 7a9d93b1a62ef2a1806f198f0c9014a66c2e4091 
  src/module/manager.cpp 573df8209c3ac7a77208c87dc7d2231e0e971a85 
  src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159 
  src/tests/module.hpp 776a4263627492f1a7b360a54c83ef34d4511ae1 
  src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review71706
-----------------------------------------------------------

Ship it!



src/Makefile.am
<https://reviews.apache.org/r/29598/#comment117572>

    Should we contain this in it's own directory? It looks a bit inconsistent compared to containerizer, fetcher and scheduler


- Niklas Nielsen


On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
>   include/mesos/module.proto PRE-CREATION 
>   src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 
>   src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483 
>   src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e 
>   src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 10:15 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 
  src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483 
  src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e 
  src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 7:42 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Fixed makefile.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a 
  src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 4:03 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a 
  src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 30, 2015, 4:54 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Update Makefile to install modules.pb.h as well.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-incubating


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 6:52 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 10:12 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 8:17 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Addressed Nik's comment by moving Modules proto to mesos/module.proto.


Summary (updated)
-----------------

Moved Modules protobuf to mesos/modules.proto.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b 
  include/mesos/module.proto PRE-CREATION 
  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
  src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 5:52 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Rebased diff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/mesos.proto 859aa2fba2536b21dd2fe1f0baa2ae3417f63fdf 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 11:42 a.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review67736
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Jan. 10, 2015, 7:27 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 7:27 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/10] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review67844
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On Jan. 10, 2015, 7:27 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 7:27 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/10] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 10, 2015, 2:27 a.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs
-----

  include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 10, 2015, 2:25 a.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased diff.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 5:49 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

Added comment to address Tim's concern.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[1/10] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs (updated)
-----

  include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review67402
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.

> On Jan. 6, 2015, 5:55 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 999
> > <https://reviews.apache.org/r/29598/diff/1/?file=807126#file807126line999>
> >
> >     I think having a description of what a Library is will be better. Technically Modules is actually a collection of libraries, where each library contains a collection of modules.

That is a good idea, thanks.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review66932
-----------------------------------------------------------


On Jan. 6, 2015, 5:39 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 5:39 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Till Toenshoff <to...@me.com>.

> On Jan. 6, 2015, 10:55 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 999
> > <https://reviews.apache.org/r/29598/diff/1/?file=807126#file807126line999>
> >
> >     I think having a description of what a Library is will be better. Technically Modules is actually a collection of libraries, where each library contains a collection of modules.
> 
> Kapil Arya wrote:
>     That is a good idea, thanks.

+1


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review66932
-----------------------------------------------------------


On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review66932
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/29598/#comment110660>

    I think having a description of what a Library is will be better. Technically Modules is actually a collection of libraries, where each library contains a collection of modules.


- Timothy Chen


On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [1/9] Build Mesos Modules outside Mesos source tree.
> 
> To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
>   src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 
> 
> Diff: https://reviews.apache.org/r/29598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 29598: Moved Modules protobuf to mesos namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 5:39 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

[1/9] Build Mesos Modules outside Mesos source tree.

To expose Modules message outside the mesos source tree.  This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.


Diffs
-----

  include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
  src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
  src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
  src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b 
  src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 

Diff: https://reviews.apache.org/r/29598/diff/


Testing
-------

make check


Thanks,

Kapil Arya