You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@vxquery.apache.org by "Preston Carman (JIRA)" <ji...@apache.org> on 2012/06/19 04:56:42 UTC

[jira] [Created] (VXQUERY-33) Arithmetic Operations

Preston Carman created VXQUERY-33:
-------------------------------------

             Summary: Arithmetic Operations
                 Key: VXQUERY-33
                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
             Project: VXQuery
          Issue Type: Task
            Reporter: Preston Carman


Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preston Carman updated VXQUERY-33:
----------------------------------

    Attachment: ArithmeticOpearations4.patch

Now all functions have been stubbed out. Still need to test the date related functions.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOpearations4.patch, ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396485#comment-13396485 ] 

Preston Carman commented on VXQUERY-33:
---------------------------------------

When running a query with the new patch, I get the following message three times. For example:


Jun 18, 2012 8:49:36 PM edu.uci.ics.hyracks.algebricks.core.jobgen.impl.JobGenHelper mkRecordDescriptor
WARNING: No type for variable $$3
Jun 18, 2012 8:49:36 PM edu.uci.ics.hyracks.algebricks.core.jobgen.impl.JobGenHelper mkRecordDescriptor
WARNING: No type for variable $$3
Jun 18, 2012 8:49:36 PM edu.uci.ics.hyracks.algebricks.core.jobgen.impl.JobGenHelper mkRecordDescriptor
WARNING: No type for variable $$3

Do you know what causes this?

                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preston Carman reassigned VXQUERY-33:
-------------------------------------

    Assignee: Preston Carman  (was: Till Westmann)
    
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Preston Carman
>              Labels: patch
>         Attachments: ArithmeticOpearations4.patch, ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (VXQUERY-33) Arithmetic Operations

Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Westmann reassigned VXQUERY-33:
------------------------------------

    Assignee: Till Westmann
    
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Vinayak Borkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406750#comment-13406750 ] 

Vinayak Borkar commented on VXQUERY-33:
---------------------------------------

I think we will need to implement the arithmetic operations fo decimal without first converting it to a double. If the spec does not list a particular combination, remove it.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preston Carman updated VXQUERY-33:
----------------------------------

    Attachment: ArithmeticOperations3.patch

Removed the copyright code and now it only has stubbed out functions for XSDecimalPointable. The patch includes subtract, multiply and divide for integer (long), double, float, YMDuration and DTDuration.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preston Carman resolved VXQUERY-33.
-----------------------------------

    Resolution: Fixed

The main work has been completed and any issues can be opened in separate tickets. In revision 1365680 the exceptions were updated to be more detailed to the exceptions thrown.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Preston Carman
>              Labels: patch
>         Attachments: ArithmeticOpearations4.patch, ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preston Carman updated VXQUERY-33:
----------------------------------

    Attachment: ArthmeticOperations2.patch

Lastest group of changes.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396606#comment-13396606 ] 

Till Westmann commented on VXQUERY-33:
--------------------------------------

Committed ArithmeticOperations3.patch at rev 1351603 - the operations aren't completely done (or tested) but the first few manual tests worked.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406710#comment-13406710 ] 

Preston Carman commented on VXQUERY-33:
---------------------------------------

I was going through the list operate functions and the types they work on. I found an operate function for YMDuration and Time. The specification does not list this combination as possible for addition, subtract, multiply or divide. Should these functions be removed or just left with a "throw new UnsupportedOperationException();"?
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405494#comment-13405494 ] 

Preston Carman commented on VXQUERY-33:
---------------------------------------

Details on each item type.
- integers (completed)
- decimals (waiting on VXQUERY-44)
- float (completed)
- double (completed)
- date (waiting on VXQUERY-43)
- time (waiting on VXQUERY-43)
- datetime (waiting on VXQUERY-43)
- year month duration (completed)
- day time duration (completed)
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408564#comment-13408564 ] 

Preston Carman commented on VXQUERY-33:
---------------------------------------

I have started the implementation for decimal and completed the multiple and divide functions. Still working on addition and subtraction.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406734#comment-13406734 ] 

Preston Carman commented on VXQUERY-33:
---------------------------------------

For decimal values, do we get enough precision by converting to double and return the result? Or do we need to create custom decimal add, subtract, multiply and divide functions.

Besides resolving the decimal question, I still need to add date, time, and datetime to add and subtract.
                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArithmeticOperations3.patch, ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VXQUERY-33) Arithmetic Operations

Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Westmann updated VXQUERY-33:
---------------------------------

    Issue Type: Sub-task  (was: Task)
        Parent: VXQUERY-31
    
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>              Labels: patch
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (VXQUERY-33) Arithmetic Operations

Posted by "Vinayak Borkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VXQUERY-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396465#comment-13396465 ] 

Vinayak Borkar commented on VXQUERY-33:
---------------------------------------

Preston,

Here is the correct copyright text to use.


/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements.  See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License.  You may obtain a copy of the License at
*
*     http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

                
> Arithmetic Operations
> ---------------------
>
>                 Key: VXQUERY-33
>                 URL: https://issues.apache.org/jira/browse/VXQUERY-33
>             Project: VXQuery
>          Issue Type: Sub-task
>            Reporter: Preston Carman
>            Assignee: Till Westmann
>              Labels: patch
>         Attachments: ArthmeticOperations2.patch
>
>
> Build the arithmetic operations for all add, subtrack, multiply and divide actions. These operations shall work for integers, decimals, float, double, date, time, datetime, year month duration and day time duration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira