You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2017/08/19 00:06:16 UTC

svn commit: r1805479 - in /myfaces/core/branches/2.3.x/api/src/main/java/javax/faces: application/ component/ component/behavior/ validator/

Author: tandraschko
Date: Sat Aug 19 00:06:15 2017
New Revision: 1805479

URL: http://svn.apache.org/viewvc?rev=1805479&view=rev
Log:
MYFACES-4137 Apply NetBeans performance hints

Modified:
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/NavigationCase.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/ViewHandler.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/UIViewRoot.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/_DeltaStateHelper.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_AjaxBehaviorDeltaStateHelper.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_DeltaStateHelper.java
    myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/validator/BeanValidator.java

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/NavigationCase.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/NavigationCase.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/NavigationCase.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/NavigationCase.java Sat Aug 19 00:06:15 2017
@@ -278,7 +278,7 @@ public class NavigationCase
             builder.append("  ");
             builder.append("<redirect include-view-params=\"");
             builder.append(_includeViewParams);
-            if (_parameters != null && _parameters.size() != 0)
+            if (_parameters != null && !_parameters.isEmpty())
             {
                 builder.append("\">\n");
                 for (Map.Entry<String, List<String>> entry : _parameters.entrySet())

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/ViewHandler.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/ViewHandler.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/ViewHandler.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/application/ViewHandler.java Sat Aug 19 00:06:15 2017
@@ -152,7 +152,7 @@ public abstract class ViewHandler
         if (indexOf != -1)
         {
             String tempEnc = contentType.substring(indexOf); // charset=UTF-8
-            encoding = tempEnc.substring(tempEnc.indexOf("=") + 1); // UTF-8
+            encoding = tempEnc.substring(tempEnc.indexOf('=') + 1); // UTF-8
             if (encoding.length() == 0)
             {
                 encoding = null;

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/UIViewRoot.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/UIViewRoot.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/UIViewRoot.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/UIViewRoot.java Sat Aug 19 00:06:15 2017
@@ -1534,7 +1534,7 @@ public class UIViewRoot extends UICompon
                 //No values
                 return null;
             }
-            else if (parentSaved == null && _viewScope != null && _viewScope.size() == 0
+            else if (parentSaved == null && _viewScope != null && _viewScope.isEmpty()
                 && !(_viewScope instanceof StateHolder) )
             {
                 //Empty view scope, no values

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/_DeltaStateHelper.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/_DeltaStateHelper.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/_DeltaStateHelper.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/_DeltaStateHelper.java Sat Aug 19 00:06:15 2017
@@ -660,7 +660,7 @@ class _DeltaStateHelper implements State
                 }
             }
         }
-        if (serializableMap == null || serializableMap.size() == 0)
+        if (serializableMap == null || serializableMap.isEmpty())
         {
             return null;
         }

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_AjaxBehaviorDeltaStateHelper.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_AjaxBehaviorDeltaStateHelper.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_AjaxBehaviorDeltaStateHelper.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_AjaxBehaviorDeltaStateHelper.java Sat Aug 19 00:06:15 2017
@@ -394,7 +394,7 @@ class _AjaxBehaviorDeltaStateHelper<A ex
     {
         Map serializableMap = (isInitialStateMarked()) ? _deltas : _fullState;
 
-        if (serializableMap == null || serializableMap.size() == 0)
+        if (serializableMap == null || serializableMap.isEmpty())
         {
             return null;
         }

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_DeltaStateHelper.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_DeltaStateHelper.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_DeltaStateHelper.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/component/behavior/_DeltaStateHelper.java Sat Aug 19 00:06:15 2017
@@ -498,7 +498,7 @@ class _DeltaStateHelper <A extends AjaxB
     {
         Map serializableMap = (isInitialStateMarked()) ? _deltas : _fullState;
 
-        if (serializableMap == null || serializableMap.size() == 0)
+        if (serializableMap == null || serializableMap.isEmpty())
         {
             return null;
         }

Modified: myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/validator/BeanValidator.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/validator/BeanValidator.java?rev=1805479&r1=1805478&r2=1805479&view=diff
==============================================================================
--- myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/validator/BeanValidator.java (original)
+++ myfaces/core/branches/2.3.x/api/src/main/java/javax/faces/validator/BeanValidator.java Sat Aug 19 00:06:15 2017
@@ -403,7 +403,7 @@ public class BeanValidator implements Va
             for (String clazz : classes)
             {
                 clazz = clazz.trim();
-                if (!clazz.equals(""))
+                if (!clazz.isEmpty())
                 {
                     Class<?> theClass = null;
                     ClassLoader cl = null;