You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/12 18:52:11 UTC

[GitHub] CodingCat commented on a change in pull request #9389: [SUBMODULE] Upgrade ps-lite to the latest version

CodingCat commented on a change in pull request #9389: [SUBMODULE] Upgrade ps-lite to the latest version
URL: https://github.com/apache/incubator-mxnet/pull/9389#discussion_r161298845
 
 

 ##########
 File path: src/kvstore/kvstore.cc
 ##########
 @@ -26,8 +26,10 @@
 #include <stdlib.h>
 #include <dmlc/logging.h>
 #include "./kvstore_local.h"
+
 #if MXNET_USE_DIST_KVSTORE
 #include "./kvstore_dist.h"
+std::atomic<int> mxnet::kvstore::KVStoreDist::customer_id_{0};
 
 Review comment:
   yes, it is supposed to be singleton, 
   
   it is used when creating a new worker https://github.com/apache/incubator-mxnet/pull/9389/files#diff-0cd6fcb2cd941d4c4a829bb3d7ea3d63R54
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services