You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Mladen Turk <mt...@apache.org> on 2008/04/24 17:25:31 UTC
[PATCH] Some windows build enhancements
Hi,
libapreq is missing .rc file, so here is a standard ASF one.
Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
in the same way as APR declares so that dllexport/dllimport
get correctly handled.
Regards
--
(TM)
Re: [PATCH] Some windows build enhancements
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Mladen Turk wrote:
> ACK.
> There was one small typo and it seems I have the karma for commits,
> so I've fixed it directly.
>
> I suppose the fix has to go to the 2.10 branch as well.
I haven't seen the svn commit mail on apreq-cvs yet ?
Yes, please fix it on branches/v2.10 as well.
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com)
c:703.336.9354
Consultant / http://p6m7g8.net/Resume/resume.txt
http://riderway.com / http://ridecharge.com
1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Re: [PATCH] Some windows build enhancements
Posted by Mladen Turk <mt...@apache.org>.
Philip M. Gollucci wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Mladen Turk wrote:
> | Hi,
> |
> | libapreq is missing .rc file, so here is a standard ASF one.
> | Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
> | in the same way as APR declares so that dllexport/dllimport
> | get correctly handled.
> Hi Mladen,
>
> Thanks for your work on this. In the future, please submit patches
> piece wise.
>
> Committed to trunk: 651366, 651374, 651381, 651385, 651388
>
> backported to v2_10 branch: 651399.
>
ACK.
There was one small typo and it seems I have the karma for commits,
so I've fixed it directly.
I suppose the fix has to go to the 2.10 branch as well.
Regards
--
(TM)
Re: [PATCH] Some windows build enhancements
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mladen Turk wrote:
| Hi,
|
| libapreq is missing .rc file, so here is a standard ASF one.
| Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
| in the same way as APR declares so that dllexport/dllimport
| get correctly handled.
Hi Mladen,
Thanks for your work on this. In the future, please submit patches
piece wise.
Committed to trunk: 651366, 651374, 651381, 651385, 651388
backported to v2_10 branch: 651399.
- --
- ------------------------------------------------------------------------
Philip M. Gollucci (philip@ridecharge.com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.8 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIEO3fdbiP+9ubjBwRAnNVAJ0SQj0/AH0uKv2i2uqs7pjoWyE5zACdE2sl
Q5zb1EHDh1GuAetL/YNkg2k=
=0wpi
-----END PGP SIGNATURE-----