[jira] [Commented] (FINERACT-630) Bulk import to allow importing loan with decimal interest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695719#comment-16695719 ] 

ASF GitHub Bot commented on FINERACT-630:
-----------------------------------------

MexinaD closed pull request #455: FINERACT-630 Allow decimal interest in a sheet to import loan
URL: https://github.com/apache/fineract/pull/455
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loan/LoanWorkbookPopulator.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loan/LoanWorkbookPopulator.java
index 409eed58a..2cbb18e59 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loan/LoanWorkbookPopulator.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loan/LoanWorkbookPopulator.java
@@ -170,7 +170,7 @@ private void setRules(Sheet worksheet,String dateFormat) {
 				.createIntegerConstraint(DataValidationConstraint.OperatorType.GREATER_OR_EQUAL, "=$M1*$N1", null);
 		DataValidationConstraint interestFrequencyConstraint = validationHelper
 				.createFormulaListConstraint("INDIRECT(CONCATENATE(\"INTEREST_FREQUENCY_\",$E1))");
-		DataValidationConstraint interestConstraint = validationHelper.createIntegerConstraint(
+		DataValidationConstraint interestConstraint = validationHelper.createDecimalConstraint(
 				DataValidationConstraint.OperatorType.BETWEEN, "=INDIRECT(CONCATENATE(\"MIN_INTEREST_\",$E1))",
 				"=INDIRECT(CONCATENATE(\"MAX_INTEREST_\",$E1))");
 		DataValidationConstraint amortizationConstraint = validationHelper
@@ -562,4 +562,4 @@ private void setNames(Sheet worksheet) {
 		}
 	}
 
-}
\ No newline at end of file
+}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bulk import to allow importing loan with decimal interest
> ---------------------------------------------------------
>
>                 Key: FINERACT-630
>                 URL: https://issues.apache.org/jira/browse/FINERACT-630
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Loan
>            Reporter: Mexina Daniel
>            Priority: Major
>              Labels: LOAN, bulkimport, gsoc, p1
>
> For now the downloaded sheets to import loans does not allow the interest which is of decimal value.
> The platform should allow both decimals and without decimal values of interest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)