You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Christofer Dutz <ch...@c-ware.de> on 2021/03/07 13:43:20 UTC
Merge the compiler-pr for distribution alignment?
Hi all,
it would simplify testing the distribution stuff a lot, if this PR would be merged:
Feature/distribution allignment by chrisdutz * Pull Request #180 * apache/royale-compiler (github.com)<https://github.com/apache/royale-compiler/pull/180>
It simply packs all scripts in the compiler bin directory into an additional jar which can then be downloaded by maven.
With this people wanting to test-drive the distribution changes don't also have to checkout and build the compiler.
It shouldn't have any other side-effects.
Chris
Re: Merge the compiler-pr for distribution alignment?
Posted by Harbs <ha...@gmail.com>.
No. If there are issues they should be resolved. I don’t understand Maven well enough to have a technical opinion.
I was just saying that it seems useful for a release, so I’m interested in this getting it resolved quickly.
Thanks,
Harbs
> On Mar 7, 2021, at 5:27 PM, Piotr Zarzycki <pi...@gmail.com> wrote:
>
> Harbs,
>
> Are you proposing merge this even with issue which I have ?
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 16:24, Harbs <ha...@gmail.com> wrote:
>
>> I’m interested in doing a release ASAP. This seems really useful for
>> releasing.
>>
>> I’m also not sure if it makes sense to first integrate Josh’s work on
>> playerglobal.
>>
>> Josh, are you finished that or is there more to do?
>>
>> Thanks,
>> Harbs
>>
>>> On Mar 7, 2021, at 3:43 PM, Christofer Dutz <ch...@c-ware.de>
>> wrote:
>>>
>>> Hi all,
>>>
>>> it would simplify testing the distribution stuff a lot, if this PR would
>> be merged:
>>> Feature/distribution allignment by chrisdutz * Pull Request #180 *
>> apache/royale-compiler (github.com)<
>> https://github.com/apache/royale-compiler/pull/180>
>>>
>>> It simply packs all scripts in the compiler bin directory into an
>> additional jar which can then be downloaded by maven.
>>>
>>> With this people wanting to test-drive the distribution changes don't
>> also have to checkout and build the compiler.
>>>
>>> It shouldn't have any other side-effects.
>>>
>>> Chris
>>
>> --
>
> Piotr Zarzycki
Re: Merge the compiler-pr for distribution alignment?
Posted by Piotr Zarzycki <pi...@gmail.com>.
Harbs,
Are you proposing merge this even with issue which I have ?
Thanks,
Piotr
On Sun, 7 Mar 2021 at 16:24, Harbs <ha...@gmail.com> wrote:
> I’m interested in doing a release ASAP. This seems really useful for
> releasing.
>
> I’m also not sure if it makes sense to first integrate Josh’s work on
> playerglobal.
>
> Josh, are you finished that or is there more to do?
>
> Thanks,
> Harbs
>
> > On Mar 7, 2021, at 3:43 PM, Christofer Dutz <ch...@c-ware.de>
> wrote:
> >
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR would
> be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes don't
> also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
>
> --
Piotr Zarzycki
Re: Merge the compiler-pr for distribution alignment?
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
There's still more work to do on playerglobal. I might be done by the end
of March, but it's possible that it will go into April. The build changes
may be a little tricky on the Ant side. If you want to do a release before
I'm done, that's fine. What I've already done adds an extra file or two
that won't hurt anything. The existing build with Adobe's playerglobal is
still the default and working fine.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sun, Mar 7, 2021 at 7:24 AM Harbs <ha...@gmail.com> wrote:
> I’m interested in doing a release ASAP. This seems really useful for
> releasing.
>
> I’m also not sure if it makes sense to first integrate Josh’s work on
> playerglobal.
>
> Josh, are you finished that or is there more to do?
>
> Thanks,
> Harbs
>
> > On Mar 7, 2021, at 3:43 PM, Christofer Dutz <ch...@c-ware.de>
> wrote:
> >
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR would
> be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes don't
> also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
>
>
Re: Merge the compiler-pr for distribution alignment?
Posted by Harbs <ha...@gmail.com>.
I’m interested in doing a release ASAP. This seems really useful for releasing.
I’m also not sure if it makes sense to first integrate Josh’s work on playerglobal.
Josh, are you finished that or is there more to do?
Thanks,
Harbs
> On Mar 7, 2021, at 3:43 PM, Christofer Dutz <ch...@c-ware.de> wrote:
>
> Hi all,
>
> it would simplify testing the distribution stuff a lot, if this PR would be merged:
> Feature/distribution allignment by chrisdutz * Pull Request #180 * apache/royale-compiler (github.com)<https://github.com/apache/royale-compiler/pull/180>
>
> It simply packs all scripts in the compiler bin directory into an additional jar which can then be downloaded by maven.
>
> With this people wanting to test-drive the distribution changes don't also have to checkout and build the compiler.
>
> It shouldn't have any other side-effects.
>
> Chris
Re: Merge the compiler-pr for distribution alignment?
Posted by Piotr Zarzycki <pi...@gmail.com>.
*I don’t see the reason.
On Sun, 7 Mar 2021 at 16:25, Piotr Zarzycki <pi...@gmail.com>
wrote:
> When it will work for me I will be +1 for merge. When I tested on Friday
> it didn’t work, so I do see reason why it should be on dev.
>
> On Sun, 7 Mar 2021 at 16:07, Christofer Dutz <ch...@c-ware.de>
> wrote:
>
>> It's not a hurry,
>>
>> But it's a side-effect free merge and if there are others wanting to join
>> in (Especially Ant folks will probably be interested)
>> I thought this would simplify things for these non-Maven-natives.
>>
>> Chris
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Piotr Zarzycki <pi...@gmail.com>
>> Gesendet: Sonntag, 7. März 2021 15:29
>> An: dev@royale.apache.org
>> Betreff: Re: Merge the compiler-pr for distribution alignment?
>>
>> Chris,
>>
>> I personally don’t have any problems with testing when it’s on branch.
>> Not sure what’s the hurry with that?
>>
>> I should have time to make another test after your commit on
>> Monday/Tuesday.
>>
>> Thanks,
>> Piotr
>>
>> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz <ch...@c-ware.de>
>> wrote:
>>
>> > Hi all,
>> >
>> > it would simplify testing the distribution stuff a lot, if this PR
>> > would be merged:
>> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
>> > apache/royale-compiler (github.com)<
>> > https://github.com/apache/royale-compiler/pull/180>
>> >
>> > It simply packs all scripts in the compiler bin directory into an
>> > additional jar which can then be downloaded by maven.
>> >
>> > With this people wanting to test-drive the distribution changes don't
>> > also have to checkout and build the compiler.
>> >
>> > It shouldn't have any other side-effects.
>> >
>> > Chris
>> >
>> --
>>
>> Piotr Zarzycki
>>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: Merge the compiler-pr for distribution alignment?
Posted by Greg Dove <gr...@gmail.com>.
Hi Chris, I haven't followed the discussion until now, that seems pretty
clear to me. The compiler part merge sounds fine to me the way you describe
it - it sounds like it is something that is inevitable at some point, but
'harmless' at any point, right?
I'm sorry I have been a bit 'absent' because of workload, I will aim to
find time to test this during this week (irrespective of whether the
compiler change is merged or remains in the branch). I don't actually use
the IDE distribution, so I am probably not the best person to verify
anything with the distribution itself, but I can check and verify if
everything goes smoothly, at least. fwiw, I still use Intellij with that
flex-mojos 'hack' to get it working, that you revealed, and I am constantly
grateful to you for sharing that!
On Mon, Mar 8, 2021 at 7:10 AM Christofer Dutz <ch...@c-ware.de>
wrote:
> Ok ... here goes:
>
> I thought I had been clear with what I wanted to do, but it seems I
> haven't been clear enough:
> To build the new distribution, you need to checkout my feature branch in
> the asjs repo (feature/distribution-allignment)
>
> However, for this to work, you need a tiny change I have in the compiler
> repo, which creates an additional jar in the compiler's "compiler" module,
> that contains all the scripts in the bin directory. I need this so I can
> put the content in the distribution.
>
> I was proposing to only merge that change as it doesn't have any effect on
> the build of the other artifacts, but the CI server would start building
> the new artifact and make it possible for people to test my changes without
> having to checkout the changes in the compiler and building the compiler
> manually.
>
> As soon as we have the distribution in a form that it produces correct
> distributions ... then ... and only then, do I think we should merge these
> changes (all of them in the asjs repo) to develop, because then we would be
> able to technically do releases with Maven.
>
> And I'm not rushing the second merge (the one in asjs) ... This should
> take as long as it takes till the distribution is perfect.
> I just want the other one in as this simplifies things for others, that
> want to test the changes (which we clearly need)
>
> Chris
>
>
>
> -----Ursprüngliche Nachricht-----
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Sonntag, 7. März 2021 18:58
> An: dev@royale.apache.org
> Betreff: AW: Merge the compiler-pr for distribution alignment?
>
> Hi Piotr,
>
> Well, I'm not referring to my changes on asjs ... I'm referring to the
> changes on the compiler.
> All this does is create a new artifact. If you managed to build the
> compiler in my branch, then all that should have worked, worked.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 16:25
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> When it will work for me I will be +1 for merge. When I tested on Friday
> it didn’t work, so I do see reason why it should be on dev.
>
> On Sun, 7 Mar 2021 at 16:07, Christofer Dutz <ch...@c-ware.de>
> wrote:
>
> > It's not a hurry,
> >
> > But it's a side-effect free merge and if there are others wanting to
> > join in (Especially Ant folks will probably be interested) I thought
> > this would simplify things for these non-Maven-natives.
> >
> > Chris
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Sonntag, 7. März 2021 15:29
> > An: dev@royale.apache.org
> > Betreff: Re: Merge the compiler-pr for distribution alignment?
> >
> > Chris,
> >
> > I personally don’t have any problems with testing when it’s on branch.
> > Not sure what’s the hurry with that?
> >
> > I should have time to make another test after your commit on
> > Monday/Tuesday.
> >
> > Thanks,
> > Piotr
> >
> > On Sun, 7 Mar 2021 at 14:43, Christofer Dutz
> > <ch...@c-ware.de>
> > wrote:
> >
> > > Hi all,
> > >
> > > it would simplify testing the distribution stuff a lot, if this PR
> > > would be merged:
> > > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > > apache/royale-compiler (github.com)<
> > > https://github.com/apache/royale-compiler/pull/180>
> > >
> > > It simply packs all scripts in the compiler bin directory into an
> > > additional jar which can then be downloaded by maven.
> > >
> > > With this people wanting to test-drive the distribution changes
> > > don't also have to checkout and build the compiler.
> > >
> > > It shouldn't have any other side-effects.
> > >
> > > Chris
> > >
> > --
> >
> > Piotr Zarzycki
> >
> --
>
> Piotr Zarzycki
>
AW: Merge the compiler-pr for distribution alignment?
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok ... here goes:
I thought I had been clear with what I wanted to do, but it seems I haven't been clear enough:
To build the new distribution, you need to checkout my feature branch in the asjs repo (feature/distribution-allignment)
However, for this to work, you need a tiny change I have in the compiler repo, which creates an additional jar in the compiler's "compiler" module, that contains all the scripts in the bin directory. I need this so I can put the content in the distribution.
I was proposing to only merge that change as it doesn't have any effect on the build of the other artifacts, but the CI server would start building the new artifact and make it possible for people to test my changes without having to checkout the changes in the compiler and building the compiler manually.
As soon as we have the distribution in a form that it produces correct distributions ... then ... and only then, do I think we should merge these changes (all of them in the asjs repo) to develop, because then we would be able to technically do releases with Maven.
And I'm not rushing the second merge (the one in asjs) ... This should take as long as it takes till the distribution is perfect.
I just want the other one in as this simplifies things for others, that want to test the changes (which we clearly need)
Chris
-----Ursprüngliche Nachricht-----
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Sonntag, 7. März 2021 18:58
An: dev@royale.apache.org
Betreff: AW: Merge the compiler-pr for distribution alignment?
Hi Piotr,
Well, I'm not referring to my changes on asjs ... I'm referring to the changes on the compiler.
All this does is create a new artifact. If you managed to build the compiler in my branch, then all that should have worked, worked.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Sonntag, 7. März 2021 16:25
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?
When it will work for me I will be +1 for merge. When I tested on Friday it didn’t work, so I do see reason why it should be on dev.
On Sun, 7 Mar 2021 at 16:07, Christofer Dutz <ch...@c-ware.de>
wrote:
> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to
> join in (Especially Ant folks will probably be interested) I thought
> this would simplify things for these non-Maven-natives.
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz
> <ch...@c-ware.de>
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes
> > don't also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: Merge the compiler-pr for distribution alignment?
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
Well, I'm not referring to my changes on asjs ... I'm referring to the changes on the compiler.
All this does is create a new artifact. If you managed to build the compiler in my branch, then all that should have worked, worked.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Sonntag, 7. März 2021 16:25
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?
When it will work for me I will be +1 for merge. When I tested on Friday it didn’t work, so I do see reason why it should be on dev.
On Sun, 7 Mar 2021 at 16:07, Christofer Dutz <ch...@c-ware.de>
wrote:
> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to
> join in (Especially Ant folks will probably be interested) I thought
> this would simplify things for these non-Maven-natives.
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz
> <ch...@c-ware.de>
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes
> > don't also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: Merge the compiler-pr for distribution alignment?
Posted by Piotr Zarzycki <pi...@gmail.com>.
When it will work for me I will be +1 for merge. When I tested on Friday it
didn’t work, so I do see reason why it should be on dev.
On Sun, 7 Mar 2021 at 16:07, Christofer Dutz <ch...@c-ware.de>
wrote:
> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to join
> in (Especially Ant folks will probably be interested)
> I thought this would simplify things for these non-Maven-natives.
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz <ch...@c-ware.de>
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes don't
> > also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: Merge the compiler-pr for distribution alignment?
Posted by Christofer Dutz <ch...@c-ware.de>.
It's not a hurry,
But it's a side-effect free merge and if there are others wanting to join in (Especially Ant folks will probably be interested)
I thought this would simplify things for these non-Maven-natives.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Sonntag, 7. März 2021 15:29
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?
Chris,
I personally don’t have any problems with testing when it’s on branch.
Not sure what’s the hurry with that?
I should have time to make another test after your commit on Monday/Tuesday.
Thanks,
Piotr
On Sun, 7 Mar 2021 at 14:43, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> it would simplify testing the distribution stuff a lot, if this PR
> would be merged:
> Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
>
> It simply packs all scripts in the compiler bin directory into an
> additional jar which can then be downloaded by maven.
>
> With this people wanting to test-drive the distribution changes don't
> also have to checkout and build the compiler.
>
> It shouldn't have any other side-effects.
>
> Chris
>
--
Piotr Zarzycki
Re: Merge the compiler-pr for distribution alignment?
Posted by Piotr Zarzycki <pi...@gmail.com>.
Chris,
I personally don’t have any problems with testing when it’s on branch.
Not sure what’s the hurry with that?
I should have time to make another test after your commit on Monday/Tuesday.
Thanks,
Piotr
On Sun, 7 Mar 2021 at 14:43, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> it would simplify testing the distribution stuff a lot, if this PR would
> be merged:
> Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
>
> It simply packs all scripts in the compiler bin directory into an
> additional jar which can then be downloaded by maven.
>
> With this people wanting to test-drive the distribution changes don't also
> have to checkout and build the compiler.
>
> It shouldn't have any other side-effects.
>
> Chris
>
--
Piotr Zarzycki