You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2012/09/17 18:05:53 UTC

svn commit: r1386686 - /myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java

Author: lofwyr
Date: Mon Sep 17 16:05:53 2012
New Revision: 1386686

URL: http://svn.apache.org/viewvc?rev=1386686&view=rev
Log:
TOBAGO-1195: Bug in component tc:columnSelector: The checkboxes aren't initialise correctly

Modified:
    myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java

Modified: myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java?rev=1386686&r1=1386685&r2=1386686&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java (original)
+++ myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java Mon Sep 17 16:05:53 2012
@@ -282,7 +282,8 @@ public class SheetRenderer extends Layou
 
       writer.startElement(HtmlElements.TR, null);
       Markup rowMarkup = odd ? Markup.ODD : Markup.EVEN;
-      if (selectedRows.contains(rowIndex)) {
+      final boolean selected = selectedRows.contains(rowIndex);
+      if (selected) {
         rowMarkup = rowMarkup.add(Markup.SELECTED);
       }
       writer.writeClassAttribute(Classes.create(sheet, "row", rowMarkup));
@@ -330,6 +331,7 @@ public class SheetRenderer extends Layou
           final boolean disabled = ComponentUtils.getBooleanAttribute(column, Attributes.DISABLED);
           writer.startElement(HtmlElements.INPUT, null);
           writer.writeAttribute(HtmlAttributes.TYPE, HtmlInputTypes.CHECKBOX, false);
+          writer.writeAttribute(HtmlAttributes.CHECKED, selected);
           writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
           writer.writeIdAttribute(sheetId + "_data_row_selector_" + rowIndex);
           writer.writeClassAttribute(Classes.create(sheet, "columnSelector"));