You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "rickchengx (via GitHub)" <gi...@apache.org> on 2023/07/12 02:36:38 UTC
[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #14392: [Improvement-14269][API] Bind task group with project
rickchengx commented on code in PR #14392:
URL: https://github.com/apache/dolphinscheduler/pull/14392#discussion_r1260495592
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java:
##########
@@ -253,16 +252,8 @@ public Map<String, Object> queryTaskGroupByStatus(User loginUser, int pageNo, in
public Map<String, Object> queryTaskGroupByProjectCode(User loginUser, int pageNo, int pageSize, Long projectCode) {
Map<String, Object> result = new HashMap<>();
Page<TaskGroup> page = new Page<>(pageNo, pageSize);
- PageInfo<TaskGroup> emptyPageInfo = new PageInfo<>(pageNo, pageSize);
- Set<Integer> ids = resourcePermissionCheckService.userOwnedResourceIdsAcquisition(AuthorizationType.TASK_GROUP,
- loginUser.getId(), log);
Review Comment:
> All task groups belongs to current project are visible to the user who is authorized project permission.
@Radeity I agree with this.
But it seems that project permission has not been checked in each CURD operation of task group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org