[GitHub] [accumulo] milleruntime commented on issue #1501: Use TabletFile for Tablet, Scans and compaction

[GitBox <gi...@apache.org>]

milleruntime commented on issue #1501: Use TabletFile for Tablet, Scans and compaction
URL: https://github.com/apache/accumulo/pull/1501#issuecomment-583086324
 
 
   > I finished reviewing, the github feature to mark files as viewed was invaluable for this review. Is the only think using FileRef now write ahead log code?
   
   Thanks for the review.  
   
   I don't see where WAL code is using FileRef, maybe you are thinking of LogEntry?  LogEntry takes a String for filename, which I think may be another good case for TableFile, if the WAL paths are the same.
   
   FileRef is still used by the two parts I found that use directories - the GC and the old bulkImport CopyFailed FATE operation.   I thought of creating an object for TabletDir for these cases but I don't think its worth it (I couldn't come up with a graceful reuse of TabletFile without dropping ```final``` on its members) since I think we can just use Path for these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services