You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2010/12/21 18:18:53 UTC
svn commit: r1051566 -
/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
Author: danielsh
Date: Tue Dec 21 17:18:53 2010
New Revision: 1051566
URL: http://svn.apache.org/viewvc?rev=1051566&view=rev
Log:
When ignoring a warning, do so noisily if in maintainer mode.
* subversion/libsvn_ra_local/ra_plugin.c
(ignore_warnings):
In maintainer mode, output notice that an error is being ignored.
Update the comment, which was outdated by r1051559.
Modified:
subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
Modified: subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c?rev=1051566&r1=1051565&r2=1051566&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c (original)
+++ subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c Tue Dec 21 17:18:53 2010
@@ -416,7 +416,7 @@ svn_ra_local__get_schemes(apr_pool_t *po
/* Do nothing.
*
- * Why is this acceptable? As of now, FS warnings are used for only
+ * Why is this acceptable? FS warnings used to be used for only
* two things: failures to close BDB repositories and failures to
* interact with memcached in FSFS (new in 1.6). In 1.5 and earlier,
* we did not call svn_fs_set_warning_func in ra_local, which means
@@ -433,6 +433,9 @@ static void
ignore_warnings(void *baton,
svn_error_t *err)
{
+#ifdef SVN_DEBUG
+ SVN_DBG(("Ignoring FS warning %ld\n", err ? err->apr_err : 0));
+#endif
return;
}
Re: svn commit: r1051566 -
/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
Posted by Daniel Shahaf <da...@apache.org>.
Julian Foad wrote on Wed, Dec 22, 2010 at 12:34:05 +0000:
> danielsh@apache.org wrote:
> > When ignoring a warning, do so noisily if in maintainer mode.
> >
> > * subversion/libsvn_ra_local/ra_plugin.c
> > (ignore_warnings):
> > In maintainer mode, output notice that an error is being ignored.
> > Update the comment, which was outdated by r1051559.
>
> subversion/libsvn_ra_local/ra_plugin.c: In function ‘ignore_warnings’:
> subversion/libsvn_ra_local/ra_plugin.c:437: warning: format ‘%ld’
> expects type ‘long int’, but argument 2 has type ‘int’
>
Thanks, r1051886.
(There is no APR_STATUS_T_FMT, but our maintainer-mode printing uses %d,
so I went with that.)
> - Julian
>
>
> > Modified: subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
> > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c?rev=1051566&r1=1051565&r2=1051566&view=diff
> > ==============================================================================
> > --- subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c (original)
> > +++ subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c Tue Dec 21 17:18:53 2010
> > @@ -416,7 +416,7 @@ svn_ra_local__get_schemes(apr_pool_t *po
> >
> > /* Do nothing.
> > *
> > - * Why is this acceptable? As of now, FS warnings are used for only
> > + * Why is this acceptable? FS warnings used to be used for only
> > * two things: failures to close BDB repositories and failures to
> > * interact with memcached in FSFS (new in 1.6). In 1.5 and earlier,
> > * we did not call svn_fs_set_warning_func in ra_local, which means
> > @@ -433,6 +433,9 @@ static void
> > ignore_warnings(void *baton,
> > svn_error_t *err)
> > {
> > +#ifdef SVN_DEBUG
> > + SVN_DBG(("Ignoring FS warning %ld\n", err ? err->apr_err : 0));
> > +#endif
> > return;
> > }
>
>
Re: svn commit: r1051566 -
/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
Posted by Julian Foad <ju...@wandisco.com>.
danielsh@apache.org wrote:
> When ignoring a warning, do so noisily if in maintainer mode.
>
> * subversion/libsvn_ra_local/ra_plugin.c
> (ignore_warnings):
> In maintainer mode, output notice that an error is being ignored.
> Update the comment, which was outdated by r1051559.
subversion/libsvn_ra_local/ra_plugin.c: In function ‘ignore_warnings’:
subversion/libsvn_ra_local/ra_plugin.c:437: warning: format ‘%ld’
expects type ‘long int’, but argument 2 has type ‘int’
- Julian
> Modified: subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c?rev=1051566&r1=1051565&r2=1051566&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c Tue Dec 21 17:18:53 2010
> @@ -416,7 +416,7 @@ svn_ra_local__get_schemes(apr_pool_t *po
>
> /* Do nothing.
> *
> - * Why is this acceptable? As of now, FS warnings are used for only
> + * Why is this acceptable? FS warnings used to be used for only
> * two things: failures to close BDB repositories and failures to
> * interact with memcached in FSFS (new in 1.6). In 1.5 and earlier,
> * we did not call svn_fs_set_warning_func in ra_local, which means
> @@ -433,6 +433,9 @@ static void
> ignore_warnings(void *baton,
> svn_error_t *err)
> {
> +#ifdef SVN_DEBUG
> + SVN_DBG(("Ignoring FS warning %ld\n", err ? err->apr_err : 0));
> +#endif
> return;
> }