You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Alin Dreghiciu (JIRA)" <ji...@apache.org> on 2009/10/15 12:28:31 UTC
[jira] Created: (FELIX-1757) Completer for session scopes
Completer for session scopes
----------------------------
Key: FELIX-1757
URL: https://issues.apache.org/jira/browse/FELIX-1757
Project: Felix
Issue Type: Improvement
Components: Karaf
Reporter: Alin Dreghiciu
Priority: Minor
GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1757) Completer for session scopes
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alin Dreghiciu updated FELIX-1757:
----------------------------------
Attachment: FELIX-1757.patch
Attached a patch that adds a completer that is session scope aware.
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Priority: Minor
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1757) Completer for session scopes
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alin Dreghiciu updated FELIX-1757:
----------------------------------
Comment: was deleted
(was: Forget about first patch ;))
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.0.2
>
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1757) Completer for session scopes
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alin Dreghiciu updated FELIX-1757:
----------------------------------
Attachment: (was: FELIX-1757.patch)
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Priority: Minor
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1757) Completer for session scopes
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alin Dreghiciu updated FELIX-1757:
----------------------------------
Attachment: FELIX-1757.patch
Forget about first patch ;)
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Priority: Minor
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1757) Completer for session scopes
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-1757.
------------------------------------
Resolution: Fixed
Fix Version/s: karaf-1.0.2
Assignee: Guillaume Nodet
Sorry, I thought your comment "forget about the first patch" was referring to the current one, so i had not reviewed it.
I've committed the patch since it works great !
Thx a lot.
Committing to https://svn.apache.org/repos/asf/felix/trunk ...
A karaf/shell/console/src/main/java/org/apache/felix/karaf/shell/console/completer/SessionScopeCompleter.java
M karaf/shell/console/src/main/java/org/apache/felix/karaf/shell/console/jline/Console.java
Committed r825825
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.0.2
>
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1757) Completer for session scopes
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766195#action_12766195 ]
Guillaume Nodet commented on FELIX-1757:
----------------------------------------
We need to enhance the CommandsCompleter for that, but I think it also requires a change of the Completer api, because the completers are global and have no way to access the scope variable nor the session.
I think the session should be passed as an additional argument in the complete() method.
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Priority: Minor
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1757) Completer for session scopes
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766289#action_12766289 ]
Alin Dreghiciu commented on FELIX-1757:
---------------------------------------
If the changes are so intrusive better forget about. But my patch (attached) worked for me. Did you gave it a try?
> Completer for session scopes
> ----------------------------
>
> Key: FELIX-1757
> URL: https://issues.apache.org/jira/browse/FELIX-1757
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Alin Dreghiciu
> Priority: Minor
> Attachments: FELIX-1757.patch
>
>
> GoGo has support for scopes (session var "SCOPE") which allows one to not add the prefix like "osgi:".
> Karaf shell completers does not support this scope so when entering "li" or "sh" and pressing tab the completer will not find the "osgi:list" or "osgi:shutdown".
> There will be a good addition to hav a completer that knows about scopes and can handle the situation described above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.