[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21993: [WIP]feat: Axis sort in the Bar Chart V2

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21993:
URL: https://github.com/apache/superset/pull/21993#discussion_r1013818589


##########
superset/utils/pandas_postprocessing/sort.py:
##########
@@ -14,22 +14,34 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from typing import Dict
+from typing import List, Optional, Union
 
 from pandas import DataFrame
 
 from superset.utils.pandas_postprocessing.utils import validate_column_args
 
 
-@validate_column_args("columns")
-def sort(df: DataFrame, columns: Dict[str, bool]) -> DataFrame:
+# pylint: disable=invalid-name
+@validate_column_args("by")
+def sort(

Review Comment:
   This function is useless as before so redesigning the interface is safe. The interface refers to Pandas.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org