You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/10/09 13:22:21 UTC

[PR] fix(home): localize dashboard load-error alert [rocketmq-dashboard]

btlqql opened a new pull request, #5873:
URL: https://github.com/apache/rocketmq-dashboard/pull/5873

   ## Why
   The dashboard load-failure fallback rendered hard-coded Chinese strings ("仪表盘加载失败" / "重试"), so English-locale users hit an untranslated error block while every other string on the page goes through `t()`.
   
   ## What changed
   - `web/src/pages/home/dashboard.tsx`: the error Alert message/description and the retry button now use `t('dashboard.loadFailed')`, `t('dashboard.loadFailedDescription')` and `t('common.retry')`.
   - `web/src/i18n/translations.ts`: add the two new keys (zh + en).
   
   ## Validation
   - New regression test in `DashboardPage.test.tsx`: with `en` locale and a rejecting `getDashboard`, the alert reads "Failed to load dashboard" with a "Retry" button and no Chinese text remains.
   - Full `DashboardPage.test.tsx` suite passes (7/7); red before the fix, green after.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(home): localize dashboard load-error alert [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #5873:
URL: https://github.com/apache/rocketmq-dashboard/pull/5873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org