You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/06/27 20:58:05 UTC
[GitHub] [solr] epugh opened a new pull request, #918: SOLR-16270: address dangling javadocs
epugh opened a new pull request, #918:
URL: https://github.com/apache/solr/pull/918
https://issues.apache.org/jira/browse/SOLR-16270
# Description
intellij is warning of "dangling javadocs" and "invalid @returns" tags.
# Solution
Fix them! Make some javadocs actuall inline comments and block comments. fix the `@returns` tags.
# Tests
manual
# Checklist
Please review the following and check all that apply:
- [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ X] I have created a Jira issue and added the issue ID to my pull request title.
- [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ X] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #918: SOLR-16270: address dangling javadocs
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #918:
URL: https://github.com/apache/solr/pull/918#issuecomment-1172380704
I am going to merge this one, and lets have a seperate ticket about commented out code... Feel free to add it to SOLR-16222 as a subtask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #918: SOLR-16270: address dangling javadocs
Posted by GitBox <gi...@apache.org>.
epugh merged PR #918:
URL: https://github.com/apache/solr/pull/918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #918: SOLR-16270: address dangling javadocs
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #918:
URL: https://github.com/apache/solr/pull/918#issuecomment-1171666352
@cpoerschke do you have
> Would be tempted to remove the commented out code that "looks like" javadocs due to spotless application.
> Would be tempted to remove the commented out code that "looks like" javadocs due to spotless application.
Do you have an example of this? I wondered about removing commented out tests as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #918: SOLR-16270: address dangling javadocs
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #918:
URL: https://github.com/apache/solr/pull/918#discussion_r912106479
##########
solr/core/src/test/org/apache/solr/TestGroupingSearch.java:
##########
@@ -1574,7 +1574,7 @@ public void testGroupingOnDateField() throws Exception {
@Test
public void testRandomGrouping() throws Exception {
- /**
Review Comment:
> ... Do you have an example of this? ...
This looks like commented out code. +1 to potentially tackling that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org