[tinkerpop] branch travis-fix updated (f459798 -> b0e8b41)

[sp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


 discard f459798  Required Maven 3.6.3
     new b0e8b41  Ignored shouldEventuallySucceedOnSameServerWithDefault

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (f459798)
            \
             N -- N -- N   refs/heads/travis-fix (b0e8b41)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .travis.yml                                                        | 4 ++--
 docs/src/dev/developer/development-environment.asciidoc            | 2 +-
 .../tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java       | 7 +++++++
 pom.xml                                                            | 2 +-
 4 files changed, 11 insertions(+), 4 deletions(-)

[tinkerpop] 01/01: Ignored shouldEventuallySucceedOnSameServerWithDefault

[sp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit b0e8b416b55fb33baa50a09cf9d32ff8642fa422
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Thu Apr 1 07:06:30 2021 -0400

    Ignored shouldEventuallySucceedOnSameServerWithDefault
    
    This test is technically failing but it had some bad assertions that made it look like it was actually passing. CTR
---
 .../tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java       | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
index ce93582..f006cc4 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
@@ -56,6 +56,7 @@ import org.apache.tinkerpop.gremlin.util.iterator.IteratorUtils;
 import org.hamcrest.core.IsInstanceOf;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.ArgumentCaptor;
 import org.mockito.Mockito;
@@ -373,6 +374,7 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
     }
 
     @Test
+    @Ignore("This test had some bad semantics that allowed it to pass even though it was technically failing")
     public void shouldEventuallySucceedOnSameServerWithDefault() throws Exception {
         stopServer();
 
@@ -390,6 +392,8 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
 
             startServer();
 
+            boolean succeedAtLeastOnce = false;
+
             // default reconnect time is 1 second so wait some extra time to be sure it has time to try to bring it
             // back to life. usually this passes on the first attempt, but docker is sometimes slow and we get failures
             // waiting for Gremlin Server to pop back up
@@ -398,12 +402,15 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
                 try {
                     final int result = client.submit("1+1").all().join().get(0).getInt();
                     assertEquals(2, result);
+                    succeedAtLeastOnce = true;
                     break;
                 } catch (Exception ignored) {
                     logger.warn("Attempt {} failed on shouldEventuallySucceedOnSameServerWithDefault", ix);
                 }
             }
 
+            assertThat(succeedAtLeastOnce, is(true));
+
         } finally {
             cluster.close();
         }