You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "lizhimins (via GitHub)" <gi...@apache.org> on 2023/07/13 03:20:38 UTC
[GitHub] [rocketmq] lizhimins commented on a diff in pull request #7003: [ISSUE #7001] Fix IndexOutOfBoundsException when process pop response
lizhimins commented on code in PR #7003:
URL: https://github.com/apache/rocketmq/pull/7003#discussion_r1261933166
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -1173,7 +1173,10 @@ private static Map<String, List<Long>> buildQueueOffsetSortedMap(String topic, L
Long.parseLong(messageExt.getProperty(MessageConst.PROPERTY_INNER_MULTI_QUEUE_OFFSET)));
continue;
}
- key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(), messageExt.getQueueId());
+ // Value of POP_CK is used to determine whether it is a pop retry,
+ // cause topic could be rewritten by broker.
+ key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(),
+ messageExt.getProperty(MessageConst.PROPERTY_POP_CK), messageExt.getQueueId());
Review Comment:
有点忘了，如果是新版本 client - 低版本 broker 这里是不是可行 @xdkxlk
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -1173,7 +1173,10 @@ private static Map<String, List<Long>> buildQueueOffsetSortedMap(String topic, L
Long.parseLong(messageExt.getProperty(MessageConst.PROPERTY_INNER_MULTI_QUEUE_OFFSET)));
continue;
}
- key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(), messageExt.getQueueId());
+ // Value of POP_CK is used to determine whether it is a pop retry,
+ // cause topic could be rewritten by broker.
+ key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(),
+ messageExt.getProperty(MessageConst.PROPERTY_POP_CK), messageExt.getQueueId());
Review Comment:
有点忘了，如果是新版本 client - 低版本 broker 这里是不是可行 @xdkxlk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org