You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/14 09:44:26 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2533: Make the number of queue/signal used by irq handler configurable
xiaoxiang781216 opened a new pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533
## Summary
these structure can't be dynamically allocated in any irq handler so it's important to let the user extend the number as needed
## Impact
No, since the default value same as before
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542406930
##########
File path: sched/mqueue/mqueue.h
##########
@@ -53,12 +53,6 @@
#define NUM_MSG_DESCRIPTORS 4
-/* This defines the number of messages to set aside for exclusive use by
- * interrupt handlers
- */
-
-#define NUM_INTERRUPT_MSGS 8
Review comment:
Yes, and since we always save the normalize(or smallest) defconfig now, it always require kconfig-frontend to expend defconfig to .config. And then all default value will bring back by the tools automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2533: Make the number of queue/signal used by irq handler configurable
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542386036
##########
File path: sched/mqueue/mqueue.h
##########
@@ -53,12 +53,6 @@
#define NUM_MSG_DESCRIPTORS 4
-/* This defines the number of messages to set aside for exclusive use by
- * interrupt handlers
- */
-
-#define NUM_INTERRUPT_MSGS 8
Review comment:
It could be a good idea to include a fail-safe protection:
#if !defined(CONFIG_PREALLOC_MQ_IRQ_MSGS)
#define CONFIG_PREALLOC_MQ_IRQ_MSGS 8
#endif
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542402116
##########
File path: sched/mqueue/mqueue.h
##########
@@ -53,12 +53,6 @@
#define NUM_MSG_DESCRIPTORS 4
-/* This defines the number of messages to set aside for exclusive use by
- * interrupt handlers
- */
-
-#define NUM_INTERRUPT_MSGS 8
Review comment:
> It could be a good idea to include a fail-safe protection:
>
> #if !defined(CONFIG_PREALLOC_MQ_IRQ_MSGS)
> #define CONFIG_PREALLOC_MQ_IRQ_MSGS 8
> #endif
We used to do these kinds of paranoid checks back in the old days when we hand edited config files. This practice is not done anymore. We trust the Kconfig files now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542406930
##########
File path: sched/mqueue/mqueue.h
##########
@@ -53,12 +53,6 @@
#define NUM_MSG_DESCRIPTORS 4
-/* This defines the number of messages to set aside for exclusive use by
- * interrupt handlers
- */
-
-#define NUM_INTERRUPT_MSGS 8
Review comment:
Yes, and since we always save the normalize(or smallest) defconfig now, it always require kconfig-frontend to expend config. And then all default value will bring back by the tools automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org